You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Awasum Yannick <aw...@apache.org> on 2018/11/03 22:18:06 UTC
Re: Fineract CN - UI build issues
Hello Mark,
Can you throw more light on how the config settings for travis will look
like?
Myrle, Can Travis be configured on the Repos or do we need help from Infra?
On Fri, Oct 19, 2018 at 11:00 AM Mark van Veen <ma...@kuelap.io>
wrote:
> With this PR the build should work again:
> https://github.com/apache/fineract-cn-fims-web-app/pull/13
>
> The issue was because the use of a local component variable within a for
> loop. I still don't know 100% why its not working when doing so but for
> this implementation a for loop is not needed at all and can be replaced
> with a map.
>
> I strongly recommend to have travis ci build(or any other build tool)
> enabled to automatically run the build(to verify the build is not broken)
> and tslint(to guarantee readable, maintainable and functionally correct
> code) to avoid such issues for future pushes.
>
> Thanks,
> Mark
>
> On Fri, Oct 12, 2018 at 8:54 AM Karthik Ananthakrishnan
> <ka...@beyondsquare.com.invalid> wrote:
>
> > Thanks Kelvin. Feedback is helpful.
> >
> > Let me try and see if i can find the issue for ng build --prod.
> >
> > I will raise the PR in couple of days.
> >
> > Regards,
> > Karthik.
> >
> > On Fri, Oct 12, 2018 at 11:52 AM Kelvin Ikome <kv...@gmail.com>
> wrote:
> >
> > > Hello Kathik,
> > >
> > > I have tried the solution you came up with and it works when I build
> > using
> > > "npm run build". However, I still get the same error when I try to
> build
> > > using "ng build --prod".
> > >
> > > Please send a pull request for the fix you did and take a look at this
> > > issue on Jira (
> https://issues.apache.org/jira/browse/FINCN-96?filter=-2)
> > > related to this bug.
> > >
> > > Thanks
> > >
> > > On Fri, Oct 5, 2018 at 3:51 PM Ruphine Kengne <ruphinekengne@gmail.com
> >
> > > wrote:
> > >
> > > > Hello Karthik,
> > > >
> > > > I have done those changes to the package.json file but it did not
> solve
> > > the
> > > > build error in my case.
> > > >
> > > > Since yours worked, Please can you sent a PR for it to be merge so
> > that I
> > > > can pull ??
> > > >
> > > > Thanks
> > > > Ruphine Kengne
> > > >
> > > > On Fri, 5 Oct 2018 at 14:17, Karthik Ananthakrishnan
> > > > <ka...@beyondsquare.com.invalid> wrote:
> > > >
> > > > > Hello all,
> > > > >
> > > > > We made this below change in package.json and build worked.
> > > > >
> > > > > Before
> > > > > "runProd": "ng serve --proxy-config proxy.conf.json --prod",
> > > > > "build": "ng build --prod",
> > > > >
> > > > > After
> > > > > "runProd": "ng serve --proxy-config proxy.conf.json
> > > > *--environment=prod*",
> > > > > "build": "ng build *--environment=prod*",
> > > > >
> > > > > For people who are facing UI build error, please check.
> > > > >
> > > > > Thanks,
> > > > > Karthik
> > > > >
> > > > > On Fri, Sep 28, 2018 at 9:18 PM Karthik Ananthakrishnan <
> > > > > karthik.a@beyondsquare.com> wrote:
> > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://user-images.githubusercontent.com/33152020/46206285-1f497b00-c341-11e8-9fe9-4fdc43ecb88e.png
> > > > > >
> > > > > > Image is attached in the git branch. Link is given above.
> > > > > >
> > > > > > Regards,
> > > > > > Karthik
> > > > > >
> > > > > > On Fri, Sep 28, 2018 at 5:46 PM Awasum Yannick <
> > > > > > awasum.yannick@skylabase.com> wrote:
> > > > > >
> > > > > >> Hey Karthik,
> > > > > >>
> > > > > >> This list seems not to take attachments or pictures. Can you
> link
> > > the
> > > > > >> error
> > > > > >> to an external service and use url here?
> > > > > >> Or just paste the error in the email body.
> > > > > >>
> > > > > >>
> > > > > >> Thanks.
> > > > > >>
> > > > > >> On Fri, Sep 28, 2018 at 1:01 PM Karthik Ananthakrishnan
> > > > > >> <ka...@beyondsquare.com.invalid> wrote:
> > > > > >>
> > > > > >> > Hello All,
> > > > > >> >
> > > > > >> > I tried running the "build" command from the latest
> fims-web-app
> > > > > branch
> > > > > >> > and i am getting the following error. Is anyone facing this
> and
> > > have
> > > > > >> > resolved the issue?
> > > > > >> >
> > > > > >> > [image: UI_Build_Error.png]
> > > > > >> >
> > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Fineract CN - UI build issues
Posted by Myrle Krantz <my...@apache.org>.
Hey Awasum,
Short answer is: I don't know. While fineract-cn was still in the mifosio
repos, I was able to get travis running for lang (because it doesn't have
any dependencies to other fineract artifacts). I don't know if the same
method can be used within a gitbox repository or if Infra's involvement is
needed. The best way to find out is to try.
But whatever the answer to your question, before we can use travis for most
of the repositories, we need to start publishing artifacts to a maven
repository.
Best Regards,
Myrle
On Sat, Nov 3, 2018 at 11:18 PM Awasum Yannick <aw...@apache.org> wrote:
> Hello Mark,
>
> Can you throw more light on how the config settings for travis will look
> like?
>
> Myrle, Can Travis be configured on the Repos or do we need help from Infra?
>
> On Fri, Oct 19, 2018 at 11:00 AM Mark van Veen <ma...@kuelap.io>
> wrote:
>
> > With this PR the build should work again:
> > https://github.com/apache/fineract-cn-fims-web-app/pull/13
> >
> > The issue was because the use of a local component variable within a for
> > loop. I still don't know 100% why its not working when doing so but for
> > this implementation a for loop is not needed at all and can be replaced
> > with a map.
> >
> > I strongly recommend to have travis ci build(or any other build tool)
> > enabled to automatically run the build(to verify the build is not broken)
> > and tslint(to guarantee readable, maintainable and functionally correct
> > code) to avoid such issues for future pushes.
> >
> > Thanks,
> > Mark
> >
> > On Fri, Oct 12, 2018 at 8:54 AM Karthik Ananthakrishnan
> > <ka...@beyondsquare.com.invalid> wrote:
> >
> > > Thanks Kelvin. Feedback is helpful.
> > >
> > > Let me try and see if i can find the issue for ng build --prod.
> > >
> > > I will raise the PR in couple of days.
> > >
> > > Regards,
> > > Karthik.
> > >
> > > On Fri, Oct 12, 2018 at 11:52 AM Kelvin Ikome <kv...@gmail.com>
> > wrote:
> > >
> > > > Hello Kathik,
> > > >
> > > > I have tried the solution you came up with and it works when I build
> > > using
> > > > "npm run build". However, I still get the same error when I try to
> > build
> > > > using "ng build --prod".
> > > >
> > > > Please send a pull request for the fix you did and take a look at
> this
> > > > issue on Jira (
> > https://issues.apache.org/jira/browse/FINCN-96?filter=-2)
> > > > related to this bug.
> > > >
> > > > Thanks
> > > >
> > > > On Fri, Oct 5, 2018 at 3:51 PM Ruphine Kengne <
> ruphinekengne@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Hello Karthik,
> > > > >
> > > > > I have done those changes to the package.json file but it did not
> > solve
> > > > the
> > > > > build error in my case.
> > > > >
> > > > > Since yours worked, Please can you sent a PR for it to be merge so
> > > that I
> > > > > can pull ??
> > > > >
> > > > > Thanks
> > > > > Ruphine Kengne
> > > > >
> > > > > On Fri, 5 Oct 2018 at 14:17, Karthik Ananthakrishnan
> > > > > <ka...@beyondsquare.com.invalid> wrote:
> > > > >
> > > > > > Hello all,
> > > > > >
> > > > > > We made this below change in package.json and build worked.
> > > > > >
> > > > > > Before
> > > > > > "runProd": "ng serve --proxy-config proxy.conf.json --prod",
> > > > > > "build": "ng build --prod",
> > > > > >
> > > > > > After
> > > > > > "runProd": "ng serve --proxy-config proxy.conf.json
> > > > > *--environment=prod*",
> > > > > > "build": "ng build *--environment=prod*",
> > > > > >
> > > > > > For people who are facing UI build error, please check.
> > > > > >
> > > > > > Thanks,
> > > > > > Karthik
> > > > > >
> > > > > > On Fri, Sep 28, 2018 at 9:18 PM Karthik Ananthakrishnan <
> > > > > > karthik.a@beyondsquare.com> wrote:
> > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://user-images.githubusercontent.com/33152020/46206285-1f497b00-c341-11e8-9fe9-4fdc43ecb88e.png
> > > > > > >
> > > > > > > Image is attached in the git branch. Link is given above.
> > > > > > >
> > > > > > > Regards,
> > > > > > > Karthik
> > > > > > >
> > > > > > > On Fri, Sep 28, 2018 at 5:46 PM Awasum Yannick <
> > > > > > > awasum.yannick@skylabase.com> wrote:
> > > > > > >
> > > > > > >> Hey Karthik,
> > > > > > >>
> > > > > > >> This list seems not to take attachments or pictures. Can you
> > link
> > > > the
> > > > > > >> error
> > > > > > >> to an external service and use url here?
> > > > > > >> Or just paste the error in the email body.
> > > > > > >>
> > > > > > >>
> > > > > > >> Thanks.
> > > > > > >>
> > > > > > >> On Fri, Sep 28, 2018 at 1:01 PM Karthik Ananthakrishnan
> > > > > > >> <ka...@beyondsquare.com.invalid> wrote:
> > > > > > >>
> > > > > > >> > Hello All,
> > > > > > >> >
> > > > > > >> > I tried running the "build" command from the latest
> > fims-web-app
> > > > > > branch
> > > > > > >> > and i am getting the following error. Is anyone facing this
> > and
> > > > have
> > > > > > >> > resolved the issue?
> > > > > > >> >
> > > > > > >> > [image: UI_Build_Error.png]
> > > > > > >> >
> > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>