[GitHub] [libcloud] Kami commented on a change in pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

[GitBox <gi...@apache.org>]

Kami commented on a change in pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#discussion_r818082456



##########
File path: libcloud/compute/drivers/vcloud.py
##########
@@ -1069,11 +1069,11 @@ class VCloud_5_5_Connection(VCloud_1_5_Connection):
     def _get_auth_headers(self):
         """Compatibility for using v5.5 of the API"""
         auth_headers = super(VCloud_5_5_Connection, self)._get_auth_headers()
-        auth_headers["Accept"] = "application/*+xml;version=5.5"
+        auth_headers["Accept"] = 'application/*;version=32.0'

Review comment:
       Was that change intentional? Since it looks like test case is now failing with this change - https://github.com/apache/libcloud/runs/5153389792?check_suite_focus=true#step:11:20321.
   
   If it's not intentional, I will revert it so the tests pass and I can merge the PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org