You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by "CMoH (via GitHub)" <gi...@apache.org> on 2023/03/12 11:56:08 UTC
[GitHub] [karaf] CMoH opened a new pull request, #1715: [KARAF-7677] Improve failure report of karaf assembly
CMoH opened a new pull request, #1715:
URL: https://github.com/apache/karaf/pull/1715
Log the offending bundle if a bundle refresh occurs during assembly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] wborn commented on a diff in pull request #1715: [KARAF-7677] Improve failure report of karaf assembly
Posted by "wborn (via GitHub)" <gi...@apache.org>.
wborn commented on code in PR #1715:
URL: https://github.com/apache/karaf/pull/1715#discussion_r1139063272
##########
features/core/src/main/java/org/apache/karaf/features/internal/service/StaticInstallSupport.java:
##########
@@ -45,7 +45,7 @@ public void refreshPackages(Collection<Bundle> bundles) throws InterruptedExcept
@Override
public void updateBundle(Bundle bundle, String uri, InputStream is) throws BundleException {
- System.err.println("Update bundle is not supported in the static installer");
+ System.err.printf("Update bundle is not supported in the static installer: bundle %s, uri %s\n", bundle == null ? "null" : bundle.getSymbolicName(), uri);
Review Comment:
```suggestion
System.err.printf("Update bundle is not supported in the static installer: bundle %s, uri %s%n", bundle == null ? "null" : bundle.getSymbolicName(), uri);
```
This seems to be an issue in other places in the code base as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] CMoH commented on a diff in pull request #1715: [KARAF-7677] Improve failure report of karaf assembly
Posted by "CMoH (via GitHub)" <gi...@apache.org>.
CMoH commented on code in PR #1715:
URL: https://github.com/apache/karaf/pull/1715#discussion_r1140021056
##########
features/core/src/main/java/org/apache/karaf/features/internal/service/StaticInstallSupport.java:
##########
@@ -45,7 +45,7 @@ public void refreshPackages(Collection<Bundle> bundles) throws InterruptedExcept
@Override
public void updateBundle(Bundle bundle, String uri, InputStream is) throws BundleException {
- System.err.println("Update bundle is not supported in the static installer");
+ System.err.printf("Update bundle is not supported in the static installer: bundle %s, uri %s\n", bundle == null ? "null" : bundle.getSymbolicName(), uri);
Review Comment:
I squashed your proposed change into the commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre merged pull request #1715: [KARAF-7677] Improve failure report of karaf assembly
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1715:
URL: https://github.com/apache/karaf/pull/1715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org