[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #30154:
URL: https://github.com/apache/spark/pull/30154#discussion_r512420953



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
##########
@@ -123,8 +123,14 @@ class JDBCTableCatalog extends TableCatalog with Logging {
         "ignored: " + properties.asScala.map { case (k, v) => s"$k=$v" }.mkString("[", ", ", "]"))

Review comment:
       I haven't removed the Warning yet. The `properties` here could be `provider`, `owner`, `location`, `comment` or `TBLPROPERTIES` key value pairs. I only implemented `comment`. Seems to me these are not options in standard database CREATE TABLE syntax. I am not sure if we need to support all of them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org