[GitHub] [kafka] ijuma commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

["ijuma (via GitHub)" <gi...@apache.org>]

ijuma commented on code in PR #13275:
URL: https://github.com/apache/kafka/pull/13275#discussion_r1130403919


##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogFileUtils.java:
##########
@@ -187,4 +188,25 @@ public static Long offsetFromFile(File file) {
         return offsetFromFileName(file.getName());
     }
 
+    /**
+     * Invokes every function in `all` even if one or more functions throws an exception.
+     * If any of the functions throws an exception, the first one will be rethrown at the end with subsequent exceptions
+     * added as suppressed exceptions.
+     */
+    public static void tryAll(List<StorageAction<Void, Exception>> all) throws Exception {

Review Comment:
   A bit odd to have this method here. This class is meant to have file related utilities and this is not that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org