You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ankita Sinha <an...@freestoneinfotech.com> on 2016/09/14 11:44:02 UTC

Re: Review Request 51722: Improvement of Unit Test coverage in Ranger

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51722/
-----------------------------------------------------------

(Updated Sept. 14, 2016, 11:44 a.m.)


Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Summary (updated)
-----------------

Improvement of Unit Test coverage in Ranger


Bugs: RANGER-1170
    https://issues.apache.org/jira/browse/RANGER-1170


Repository: ranger


Description (updated)
-------

Unit Test coverage for XKeyREST, XAuditREST, TagREST, UserREST, XUserREST, RangerTagDefService and RangerTagDefServiceDef


Diffs (updated)
-----

  security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/rest/TestUserREST.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/rest/TestXKeyREST.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefServiceBase.java PRE-CREATION 

Diff: https://reviews.apache.org/r/51722/diff/


Testing
-------


Thanks,

Ankita Sinha


Re: Review Request 51722: Improvement of Unit Test coverage in Ranger

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51722/#review150670
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Sept. 14, 2016, 11:44 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51722/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 11:44 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1170
>     https://issues.apache.org/jira/browse/RANGER-1170
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Unit Test coverage for XKeyREST, XAuditREST, TagREST, UserREST, XUserREST, RangerTagDefService and RangerTagDefServiceDef
> 
> 
> Diffs
> -----
> 
>   security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/rest/TestUserREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXKeyREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefServiceBase.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51722/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Re: Review Request 51722: Improvement of Unit Test coverage in Ranger

Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51722/#review149075
-----------------------------------------------------------


Ship it!




Test exceptions are handled in different ways for different tests. It will be better to be uniform across all the tests.

- Sailaja Polavarapu


On Sept. 14, 2016, 11:44 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51722/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 11:44 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1170
>     https://issues.apache.org/jira/browse/RANGER-1170
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Unit Test coverage for XKeyREST, XAuditREST, TagREST, UserREST, XUserREST, RangerTagDefService and RangerTagDefServiceDef
> 
> 
> Diffs
> -----
> 
>   security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/rest/TestUserREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXKeyREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefServiceBase.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51722/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>