You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/23 23:55:20 UTC
[GitHub] [geode] rhoughton-pivot opened a new pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
rhoughton-pivot opened a new pull request #5291:
URL: https://github.com/apache/geode/pull/5291
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #5291:
URL: https://github.com/apache/geode/pull/5291#issuecomment-648487629
Tried to get Spring to handle this, but they punted: https://github.com/spring-projects/spring-security/issues/8733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #5291:
URL: https://github.com/apache/geode/pull/5291#issuecomment-661343930
@metatype The module that pulls those in was also getting the symbols transitively. I'm not convinced that anything we can call can hit any symbols from these particular `javax` jars. If this change to drop the duplication of license in our source-license file doesn't work, can we close this PR as will-not-fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal edited a comment on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
Posted by GitBox <gi...@apache.org>.
onichols-pivotal edited a comment on pull request #5291:
URL: https://github.com/apache/geode/pull/5291#issuecomment-654518252
> @jinmeiliao @onichols-pivotal I have not updated the source-distribution license file as part of the draft. I'd be happy to pair with someone on how to do that, once I get signoff that this is a working dependency change for us.
It looks like you just need to remove activation 1.1 (lines 269-270) from geode-assembly/src/main/dist/LICENSE
You can run the license-review script before&after to confirm `./dev-tools/release/license_review.sh -v HEAD -p https://maven.apachegeode-ci.info/snapshots/org/apache/geode/apache-geode/1.14.0-build.208/apache-geode-1.14.0-build.208.tgz`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] metatype commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
Posted by GitBox <gi...@apache.org>.
metatype commented on pull request #5291:
URL: https://github.com/apache/geode/pull/5291#issuecomment-661242217
IIUC, this removes javax.mail and javax.activation from the bundled dependencies. I believe that we need those dependencies until we remove the admin API entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #5291:
URL: https://github.com/apache/geode/pull/5291#issuecomment-654502849
@jinmeiliao @onichols-pivotal I have not updated the source-distribution license file as part of the draft. I'd be happy to pair with someone on how to do that, once I get signoff that this is a working dependency change for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot merged pull request #5291: [DRAFT] GEODE-8066: Pull up transitive dependency to clean up javax.activation and mail licenses.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot merged pull request #5291:
URL: https://github.com/apache/geode/pull/5291
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #5291:
URL: https://github.com/apache/geode/pull/5291#issuecomment-661346111
@metatype this PR is in response to the ticket you asked me to create during the last license review: GEODE-8066 Geode should not be using both activation 1.1 and javax.activation 1.2
So we are trying to go from 2 versions of a dependency to just one (not trying to get rid of it entirely).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #5291:
URL: https://github.com/apache/geode/pull/5291#issuecomment-661346610
@rhoughton-pivot don't forget to remove activation 1.1 (lines 269-270) from geode-assembly/src/main/dist/LICENSE as part of this PR, and also please add the ticket to the front of the PR title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #5291:
URL: https://github.com/apache/geode/pull/5291#issuecomment-654518252
> @jinmeiliao @onichols-pivotal I have not updated the source-distribution license file as part of the draft. I'd be happy to pair with someone on how to do that, once I get signoff that this is a working dependency change for us.
You can run the license-review script to point you to anything that might need fixing `./dev-tools/release/license_review.sh -v HEAD`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org