You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2019/10/03 13:41:00 UTC
[jira] [Commented] (CALCITE-2970) Performance issue when enabling
abstract converter for EnumerableConvertion
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943616#comment-16943616 ]
Stamatis Zampetakis commented on CALCITE-2970:
----------------------------------------------
Hey [~jinxing6042@126.com], thanks for working on this. I've seen that you did some analysis to identify the cause of this issue. For the future, it is better to include this kind of general information in the Jira rather than in the PR.
I think an important element that is missing from the analysis is the profiling information. I do understand that the change in {{EnumerableMergeJoinRule}} greatly improves the performance but how we can be sure that this rule is the one (or the only one) that needs fixing. I suppose that you could equally reduce the time by restricting matches in other rules.
> Performance issue when enabling abstract converter for EnumerableConvertion
> ---------------------------------------------------------------------------
>
> Key: CALCITE-2970
> URL: https://issues.apache.org/jira/browse/CALCITE-2970
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by making {{useAbstractConvertersForConversion}} return true, {{JDBCTest.testJoinManyWay}} will not complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)