You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/05/17 01:02:32 UTC
Review Request 21590: Added TemporaryDirectoryTest fixture to stout tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21590/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
See summary. Factored out to use in other tests (e.g., next review)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am a9269adf8f17df9ed76a4a186a66efc34bd224e3
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 194906edf42ed77d8e9643fa0a277d72f36c886d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3e511355e1faf7160442799e1e08d59b6f3b2f37
Diff: https://reviews.apache.org/r/21590/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21590: Added TemporaryDirectoryTest fixture to stout
tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21590/#review43677
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On May 21, 2014, 11:34 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21590/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 11:34 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. Factored out to use in other tests (e.g., next review)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 81eaaa982a195700b0fbab27c792025cb92abd0e
> 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 194906edf42ed77d8e9643fa0a277d72f36c886d
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 76563c258878ddab3e7a6a5c7fd49faf93465592
> 3rdparty/libprocess/3rdparty/stout/tests/utils.hpp PRE-CREATION
> src/tests/utils.hpp 3b80933dad643a0d6af15573ce67bc6e316496ea
>
> Diff: https://reviews.apache.org/r/21590/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21590: Added TemporaryDirectoryTest fixture to stout
tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21590/
-----------------------------------------------------------
(Updated May 22, 2014, 12:37 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
readded "depends on".
Repository: mesos-git
Description
-------
See summary. Factored out to use in other tests (e.g., next review)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 81eaaa982a195700b0fbab27c792025cb92abd0e
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 194906edf42ed77d8e9643fa0a277d72f36c886d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 76563c258878ddab3e7a6a5c7fd49faf93465592
3rdparty/libprocess/3rdparty/stout/tests/utils.hpp PRE-CREATION
src/tests/utils.hpp 3b80933dad643a0d6af15573ce67bc6e316496ea
Diff: https://reviews.apache.org/r/21590/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21590: Added TemporaryDirectoryTest fixture to stout
tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21590/
-----------------------------------------------------------
(Updated May 22, 2014, 12:36 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased. NNFR.
Repository: mesos-git
Description
-------
See summary. Factored out to use in other tests (e.g., next review)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 81eaaa982a195700b0fbab27c792025cb92abd0e
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 194906edf42ed77d8e9643fa0a277d72f36c886d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 76563c258878ddab3e7a6a5c7fd49faf93465592
3rdparty/libprocess/3rdparty/stout/tests/utils.hpp PRE-CREATION
src/tests/utils.hpp 3b80933dad643a0d6af15573ce67bc6e316496ea
Diff: https://reviews.apache.org/r/21590/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21590: Added TemporaryDirectoryTest fixture to stout
tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21590/
-----------------------------------------------------------
(Updated May 21, 2014, 11:34 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased.
Repository: mesos-git
Description
-------
See summary. Factored out to use in other tests (e.g., next review)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 81eaaa982a195700b0fbab27c792025cb92abd0e
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 194906edf42ed77d8e9643fa0a277d72f36c886d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 76563c258878ddab3e7a6a5c7fd49faf93465592
3rdparty/libprocess/3rdparty/stout/tests/utils.hpp PRE-CREATION
src/tests/utils.hpp 3b80933dad643a0d6af15573ce67bc6e316496ea
Diff: https://reviews.apache.org/r/21590/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21590: Added TemporaryDirectoryTest fixture to stout
tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21590/
-----------------------------------------------------------
(Updated May 20, 2014, 6:47 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased.
Repository: mesos-git
Description
-------
See summary. Factored out to use in other tests (e.g., next review)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am a9269adf8f17df9ed76a4a186a66efc34bd224e3
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 194906edf42ed77d8e9643fa0a277d72f36c886d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3e511355e1faf7160442799e1e08d59b6f3b2f37
3rdparty/libprocess/3rdparty/stout/tests/utils.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/21590/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21590: Added TemporaryDirectoryTest fixture to stout
tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21590/
-----------------------------------------------------------
(Updated May 19, 2014, 9:20 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased.
Repository: mesos-git
Description
-------
See summary. Factored out to use in other tests (e.g., next review)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am a9269adf8f17df9ed76a4a186a66efc34bd224e3
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 194906edf42ed77d8e9643fa0a277d72f36c886d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3e511355e1faf7160442799e1e08d59b6f3b2f37
3rdparty/libprocess/3rdparty/stout/tests/utils.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/21590/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21590: Added TemporaryDirectoryTest fixture to stout
tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21590/
-----------------------------------------------------------
(Updated May 17, 2014, 1:01 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
added the missing utils.hpp file.
Repository: mesos-git
Description
-------
See summary. Factored out to use in other tests (e.g., next review)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am a9269adf8f17df9ed76a4a186a66efc34bd224e3
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 194906edf42ed77d8e9643fa0a277d72f36c886d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3e511355e1faf7160442799e1e08d59b6f3b2f37
3rdparty/libprocess/3rdparty/stout/tests/utils.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/21590/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone