You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/05/02 00:05:09 UTC

[jira] [Commented] (CB-8674) [Windows] Access launch arguments

    [ https://issues.apache.org/jira/browse/CB-8674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524081#comment-14524081 ] 

ASF GitHub Bot commented on CB-8674:
------------------------------------

GitHub user robpaveza opened a pull request:

    https://github.com/apache/cordova-js/pull/108

    Experimental addition for CB-8674: Creates a 'cordova.env' object, and

    Creates a 'cordova.env' object, and then on Windows hangs the activation arguments off of cordova.env.args.  This should allow plugins to capture the activation arguments even though the 'activated' event fires before plugins load on Windows.
    
    Before merging, let's make sure the change satisfies the bug.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-js CB-8674

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-js/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
    
----
commit 6e05b62f3dee3cda3ed4d307dc1008c79d6131e2
Author: Rob Paveza <ro...@microsoft.com>
Date:   2015-05-01T21:58:46Z

    Experimental addition for CB-8674: Creates a 'cordova.env' object, and
    then on Windows hangs the activation arguments off of cordova.env.args.
    This should allow plugins to capture the activation arguments even though
    the 'activated' event fires before plugins load on Windows.

----


> [Windows] Access launch arguments
> ---------------------------------
>
>                 Key: CB-8674
>                 URL: https://issues.apache.org/jira/browse/CB-8674
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Windows, Windows 8
>            Reporter: Sebastián Katzer
>            Assignee: Jesse MacFadyen
>
> To get informed about the clicked local notification _on launch_ the plugin needs to listen for the `activated` event.
> But the `activated` event at launch is called before any plugin is loaded. Thus its not possible to access the required informations.
> Also see: https://msdn.microsoft.com/en-us/library/windows/apps/hh761468.aspx
> Is it possible to make the event arguments accessible for later usage?
> Its a blocker before the windows platform can be added to the local-notification plugin.
> https://github.com/katzer/cordova-plugin-local-notifications
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org