You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/03/02 00:26:04 UTC
[GitHub] [spark] hvanhovell opened a new pull request, #40242: [SPARK-42639][CONNECT] Add createDataFrame/createDataset methods
hvanhovell opened a new pull request, #40242:
URL: https://github.com/apache/spark/pull/40242
### What changes were proposed in this pull request?
This PR adds all the `SparkSession.createDataFrame(..)` and `SparkSession.createDataset(..)` methods we can support in connect. The implicit conversion that uses this is also added.
I moved the `ArrowWriter` class from sql/core to sql/catalyst for the arrow writing.
### Why are the changes needed?
API partity with the existing SQL APIs
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
I have added a number of tests to `ClientE2ETestSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40242: [SPARK-42639][CONNECT] Add createDataFrame/createDataset methods
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40242:
URL: https://github.com/apache/spark/pull/40242#issuecomment-1451399400
Thank you, @hvanhovell and @HyukjinKwon . Merged to master/3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #40242: [SPARK-42639][CONNECT] Add createDataFrame/createDataset methods
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #40242: [SPARK-42639][CONNECT] Add createDataFrame/createDataset methods
URL: https://github.com/apache/spark/pull/40242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org