You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2015/11/24 15:47:19 UTC
Review Request 40647: Updated centos6.6 installation instructions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
Bugs: MESOS-3974
https://issues.apache.org/jira/browse/MESOS-3974
Repository: mesos
Description
-------
For full support for the Docker- and MesosContainerizers we require a
relatively recent kernel. Document this dependency.
Diffs
-----
docs/getting-started.md 8e1df88fcf9e932dfc01b7455e63553ac028a904
Diff: https://reviews.apache.org/r/40647/diff/
Testing
-------
Confirmed that the test succeeds with the suggested change.
Thanks,
Benjamin Bannier
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review108002
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Nov. 25, 2015, 3:11 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:11 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
>
>
> Diffs
> -----
>
> docs/getting-started.md 8e1df88fcf9e932dfc01b7455e63553ac028a904
>
> Diff: https://reviews.apache.org/r/40647/diff/
>
>
> Testing
> -------
>
> Confirmed that the test succeeds with the suggested change.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 3:11 p.m.)
Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
Changes
-------
Added a comment explaining intent of `sed` wizardry.
Bugs: MESOS-3974
https://issues.apache.org/jira/browse/MESOS-3974
Repository: mesos
Description
-------
For full support for the Docker- and MesosContainerizers we require a
relatively recent kernel. Document this dependency.
Diffs (updated)
-----
docs/getting-started.md 8e1df88fcf9e932dfc01b7455e63553ac028a904
Diff: https://reviews.apache.org/r/40647/diff/
Testing
-------
Confirmed that the test succeeds with the suggested change.
Thanks,
Benjamin Bannier
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107998
-----------------------------------------------------------
docs/getting-started.md (line 63)
<https://reviews.apache.org/r/40647/#comment167356>
As this looks really esoteric and fragile, can we please add a comment on what we want to achieve here?
- Till Toenshoff
On Nov. 25, 2015, 1:26 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 1:26 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
>
>
> Diffs
> -----
>
> docs/getting-started.md 8e1df88fcf9e932dfc01b7455e63553ac028a904
>
> Diff: https://reviews.apache.org/r/40647/diff/
>
>
> Testing
> -------
>
> Confirmed that the test succeeds with the suggested change.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107984
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Nov. 25, 2015, 5:26 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 5:26 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
>
>
> Diffs
> -----
>
> docs/getting-started.md 8e1df88fcf9e932dfc01b7455e63553ac028a904
>
> Diff: https://reviews.apache.org/r/40647/diff/
>
>
> Testing
> -------
>
> Confirmed that the test succeeds with the suggested change.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 1:26 p.m.)
Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
Changes
-------
Addressed review comments.
Bugs: MESOS-3974
https://issues.apache.org/jira/browse/MESOS-3974
Repository: mesos
Description
-------
For full support for the Docker- and MesosContainerizers we require a
relatively recent kernel. Document this dependency.
Diffs (updated)
-----
docs/getting-started.md 8e1df88fcf9e932dfc01b7455e63553ac028a904
Diff: https://reviews.apache.org/r/40647/diff/
Testing
-------
Confirmed that the test succeeds with the suggested change.
Thanks,
Benjamin Bannier
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107934
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40647]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 24, 2015, 2:50 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 2:50 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
>
>
> Diffs
> -----
>
> docs/getting-started.md 8e1df88
>
> Diff: https://reviews.apache.org/r/40647/diff/
>
>
> Testing
> -------
>
> Confirmed that the test succeeds with the suggested change.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107971
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Nov. 24, 2015, 3:50 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 3:50 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
>
>
> Diffs
> -----
>
> docs/getting-started.md 8e1df88
>
> Diff: https://reviews.apache.org/r/40647/diff/
>
>
> Testing
> -------
>
> Confirmed that the test succeeds with the suggested change.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Nov. 25, 2015, 12:17 p.m., Bernd Mathiske wrote:
> > docs/getting-started.md, line 63
> > <https://reviews.apache.org/r/40647/diff/2/?file=1138857#file1138857line63>
> >
> > Depending on what grub version you are using, you need this instead:
> >
> > sudo sed -i "s/default=1/default=0/g" /boot/grub/grub.conf
> >
> > I suggest listing both options with a comment above.
On the platform these instructions apply to `/etc/grub.conf` is a softlink to `/boot/grub/grub.conf` so we do only need to edit this in one place. I now switched to patching the actual file `/boot/grub/grub.conf`, though.
A better solution would have been to use some smart grub config editor, like e.g., `grubby` on centos. However, since we depend on an outside source for the kernel we cannot be sure about the current revision the install command will get, and so cannot reference the kernel image that would be installed.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107974
-----------------------------------------------------------
On Nov. 25, 2015, 1:26 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 1:26 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
>
>
> Diffs
> -----
>
> docs/getting-started.md 8e1df88fcf9e932dfc01b7455e63553ac028a904
>
> Diff: https://reviews.apache.org/r/40647/diff/
>
>
> Testing
> -------
>
> Confirmed that the test succeeds with the suggested change.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107974
-----------------------------------------------------------
docs/getting-started.md (line 63)
<https://reviews.apache.org/r/40647/#comment167319>
Depending on what grub version you are using, you need this instead:
sudo sed -i "s/default=1/default=0/g" /boot/grub/grub.conf
I suggest listing both options with a comment above.
- Bernd Mathiske
On Nov. 24, 2015, 6:50 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 6:50 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
>
>
> Diffs
> -----
>
> docs/getting-started.md 8e1df88
>
> Diff: https://reviews.apache.org/r/40647/diff/
>
>
> Testing
> -------
>
> Confirmed that the test succeeds with the suggested change.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107817
-----------------------------------------------------------
Ship it!
Ship It!
- Cong Wang
On Nov. 24, 2015, 2:50 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 2:50 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
>
>
> Diffs
> -----
>
> docs/getting-started.md 8e1df88
>
> Diff: https://reviews.apache.org/r/40647/diff/
>
>
> Testing
> -------
>
> Confirmed that the test succeeds with the suggested change.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 40647: Updated centos6.6 installation instructions.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 2:50 p.m.)
Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
Bugs: MESOS-3974
https://issues.apache.org/jira/browse/MESOS-3974
Repository: mesos
Description
-------
For full support for the Docker- and MesosContainerizers we require a
relatively recent kernel. Document this dependency.
Diffs (updated)
-----
docs/getting-started.md 8e1df88
Diff: https://reviews.apache.org/r/40647/diff/
Testing
-------
Confirmed that the test succeeds with the suggested change.
Thanks,
Benjamin Bannier