You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by GitBox <gi...@apache.org> on 2020/07/21 06:59:14 UTC

[GitHub] [mahout] chrisdutz opened a new pull request #403: MAHOUT-2117 Fixing licensing issues

chrisdutz opened a new pull request #403:
URL: https://github.com/apache/mahout/pull/403


   - Updated the LICENSE.txt content
   
   ### Purpose of PR:
   Please give a short description of what this PR is for.
   
   
   ### Important ToDos
   Please mark each with an "x"
   - [X] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
   - [X] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
   - [ ] Created unit tests where appropriate
   - [X] Added licenses correct on newly added files
   - [X] Assigned JIRA to self
   - [ ] Added documentation in scala docs/java docs, and to website
   - [ ] Successfully built and ran all unit tests, verified that all tests pass locally.
   
   If all of these things aren't complete, but you still feel it is
   appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
   descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
   
   Does this change break earlier versions?
   
   Is this the beginning of a larger project for which a feature branch should be made?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [GitHub] [mahout] chrisdutz opened a new pull request #403: MAHOUT-2117 Fixing licensing issues

Posted by Christofer Dutz <ch...@c-ware.de>.
Hi all,

so I just pushed the last change that I think we needed in order to clean up any licensing issues. 
Would be cool if you could evaluate my changes and merge the PR ... I think then we're on a good base to start a new release attempt

Chris



Am 21.07.20, 08:59 schrieb "GitBox" <gi...@apache.org>:


    chrisdutz opened a new pull request #403:
    URL: https://github.com/apache/mahout/pull/403


       - Updated the LICENSE.txt content

       ### Purpose of PR:
       Please give a short description of what this PR is for.


       ### Important ToDos
       Please mark each with an "x"
       - [X] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
       - [X] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
       - [ ] Created unit tests where appropriate
       - [X] Added licenses correct on newly added files
       - [X] Assigned JIRA to self
       - [ ] Added documentation in scala docs/java docs, and to website
       - [ ] Successfully built and ran all unit tests, verified that all tests pass locally.

       If all of these things aren't complete, but you still feel it is
       appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
       descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"

       Does this change break earlier versions?

       Is this the beginning of a larger project for which a feature branch should be made?



    ----------------------------------------------------------------
    This is an automated message from the Apache Git Service.
    To respond to the message, please log on to GitHub and use the
    URL above to go to the specific comment.

    For queries about this service, please contact Infrastructure at:
    users@infra.apache.org

[GitHub] [mahout] rawkintrevo merged pull request #403: MAHOUT-2117 Fixing licensing issues

Posted by GitBox <gi...@apache.org>.
rawkintrevo merged pull request #403:
URL: https://github.com/apache/mahout/pull/403


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mahout] rawkintrevo commented on pull request #403: MAHOUT-2117 Fixing licensing issues

Posted by GitBox <gi...@apache.org>.
rawkintrevo commented on pull request #403:
URL: https://github.com/apache/mahout/pull/403#issuecomment-665134727


   Wow- epic effort @chrisdutz !! 
   
   This LGTM, sorry I didn't see it was updated as ready for review- thanks for the ping. 
   
   tg
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org