You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/10/11 01:57:28 UTC

[GitHub] spark pull request #19316: [SPARK-22097][CORE]Request an accurate memory aft...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19316#discussion_r143896120
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
    @@ -388,7 +388,13 @@ private[spark] class MemoryStore(
         // perform one final call to attempt to allocate additional memory if necessary.
         if (keepUnrolling) {
    --- End diff --
    
    shall we merge this `if` into the next `if`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org