You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/08 15:34:40 UTC
[GitHub] [commons-lang] RameshDhungel opened a new pull request #503:
[LANG-1523] Avoid unnecessary allocation in StringUtils.wrapIfMissing
RameshDhungel opened a new pull request #503: [LANG-1523] Avoid unnecessary allocation in StringUtils.wrapIfMissing
URL: https://github.com/apache/commons-lang/pull/503
It seems like the String Builder is being created after checking if the str or the wrapper is null. What we can do is check if the str is already wrapped, if so then just return the str. This would avoid the String Builder being created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] RameshDhungel commented on issue #503: [LANG-1523]
Avoid unnecessary allocation in StringUtils.wrapIfMissing
Posted by GitBox <gi...@apache.org>.
RameshDhungel commented on issue #503: [LANG-1523] Avoid unnecessary allocation in StringUtils.wrapIfMissing
URL: https://github.com/apache/commons-lang/pull/503#issuecomment-596223711
Oh okay, so this issue is already resolved then right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #503: [LANG-1523]
Avoid unnecessary allocation in StringUtils.wrapIfMissing
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #503: [LANG-1523] Avoid unnecessary allocation in StringUtils.wrapIfMissing
URL: https://github.com/apache/commons-lang/pull/503#issuecomment-599550789
> Oh okay, so this issue is already resolved then right?
@RameshDhungel
It's up to you to verify that your specific use cases are accounted for and then close this PR if you are OK with the state of git master ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #503: [LANG-1523]
Avoid unnecessary allocation in StringUtils.wrapIfMissing
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #503: [LANG-1523] Avoid unnecessary allocation in StringUtils.wrapIfMissing
URL: https://github.com/apache/commons-lang/pull/503#issuecomment-596221421
@RameshDhungel
I believe this PR conflicts with master because this change has already been merged through https://github.com/apache/commons-lang/pull/496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services