You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/23 18:38:02 UTC

[GitHub] [helix] xyuanlu commented on pull request #1456: Fix Periodic rebalancer Timer leak

xyuanlu commented on pull request #1456:
URL: https://github.com/apache/helix/pull/1456#issuecomment-715509029


   My PR is ready to be merged in. Approved by @jiajunwang 
   
   Final commit message:
   Fix Periodic rebalancer Timer leak
   In current startPeriodRebalance, two thread may interference with each other. This may result in one timer got canceled twice, two timers are created with one timer leaked. This PR changes Timer to use a SingleThreadScheduledExecutor and adds a synchronized block in start/stop PeriodRebalance.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org