You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2011/07/14 00:20:59 UTC

[jira] [Created] (PIG-2162) bin/pig should not modify user args

bin/pig should not modify user args
-----------------------------------

                 Key: PIG-2162
                 URL: https://issues.apache.org/jira/browse/PIG-2162
             Project: Pig
          Issue Type: Bug
            Reporter: Raghu Angadi
            Assignee: Raghu Angadi
         Attachments: PIG-2162.patch


PIG launcher script (bin/pig) joins all the user arguments in one string. This leads to confusion when the arguments contain spaces.
i.e. '{{bin/pig -p sub="i > 2"}}' is should not same as '{{bin/pig -p "sub" "i" ">" "2"}}', but it is.



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2162) bin/pig should not modify user args

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064919#comment-13064919 ] 

Raghu Angadi commented on PIG-2162:
-----------------------------------

There is a related issue with parsing of params inside PIG. We need to escape '=' and any space before '=' which specifying params on command line, but there is is no such restriction for using '%default'. We might need merge the parser for these two. This might a relatively minor tweak to ParamLoader.jj. 

to get equivalent of {{%declare cond 'i == 2'}} we need to use {{ -p cond='i\ \=\= 2' }}




> bin/pig should not modify user args
> -----------------------------------
>
>                 Key: PIG-2162
>                 URL: https://issues.apache.org/jira/browse/PIG-2162
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>         Attachments: PIG-2162.patch
>
>
> PIG launcher script (bin/pig) joins all the user arguments in one string. This leads to confusion when the arguments contain spaces.
> i.e. '{{bin/pig -p sub="i > 2"}}' is should not same as '{{bin/pig -p "sub" "i" ">" "2"}}', but it is.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2162) bin/pig should not modify user args

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated PIG-2162:
------------------------------

        Fix Version/s: 0.10
    Affects Version/s: 0.8.0
         Release Note: bin/pig handles args with spaces correctly.
               Status: Patch Available  (was: Open)

> bin/pig should not modify user args
> -----------------------------------
>
>                 Key: PIG-2162
>                 URL: https://issues.apache.org/jira/browse/PIG-2162
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.10
>
>         Attachments: PIG-2162.patch
>
>
> PIG launcher script (bin/pig) joins all the user arguments in one string. This leads to confusion when the arguments contain spaces.
> i.e. '{{bin/pig -p sub="i > 2"}}' is should not same as '{{bin/pig -p "sub" "i" ">" "2"}}', but it is.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2162) bin/pig should not modify user args

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated PIG-2162:
------------------------------

    Attachment: PIG-2162.patch

patch preservers the user args.

> bin/pig should not modify user args
> -----------------------------------
>
>                 Key: PIG-2162
>                 URL: https://issues.apache.org/jira/browse/PIG-2162
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>         Attachments: PIG-2162.patch
>
>
> PIG launcher script (bin/pig) joins all the user arguments in one string. This leads to confusion when the arguments contain spaces.
> i.e. '{{bin/pig -p sub="i > 2"}}' is should not same as '{{bin/pig -p "sub" "i" ">" "2"}}', but it is.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2162) bin/pig should not modify user args

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068019#comment-13068019 ] 

Raghu Angadi commented on PIG-2162:
-----------------------------------

Thanks Thejas. filed PIG-2180.

> bin/pig should not modify user args
> -----------------------------------
>
>                 Key: PIG-2162
>                 URL: https://issues.apache.org/jira/browse/PIG-2162
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.10
>
>         Attachments: PIG-2162.patch
>
>
> PIG launcher script (bin/pig) joins all the user arguments in one string. This leads to confusion when the arguments contain spaces.
> i.e. '{{bin/pig -p sub="i > 2"}}' is should not same as '{{bin/pig -p "sub" "i" ">" "2"}}', but it is.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2162) bin/pig should not modify user args

Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thejas M Nair updated PIG-2162:
-------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

+1. Patch committed to trunk.
Thanks Raghu!
Can you please open a new jira to track the issue of parsing of '=' in parameters ?

> bin/pig should not modify user args
> -----------------------------------
>
>                 Key: PIG-2162
>                 URL: https://issues.apache.org/jira/browse/PIG-2162
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.10
>
>         Attachments: PIG-2162.patch
>
>
> PIG launcher script (bin/pig) joins all the user arguments in one string. This leads to confusion when the arguments contain spaces.
> i.e. '{{bin/pig -p sub="i > 2"}}' is should not same as '{{bin/pig -p "sub" "i" ">" "2"}}', but it is.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira