[GitHub] andrzej-kaczmarek commented on a change in pull request #178: host: Add API to unpair a peer device

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #178: host: Add API to unpair a peer device
URL: https://github.com/apache/mynewt-nimble/pull/178#discussion_r218730912
 
 

 ##########
 File path: nimble/host/src/ble_store_util.c
 ##########
 @@ -210,7 +210,7 @@ ble_store_util_delete_oldest_peer(void)
         return 0;
     }
 
-    rc = ble_store_util_delete_peer(&peer_id_addrs[0]);
+    rc = ble_gap_unpair(&peer_id_addrs[0]);
 
 Review comment:
   we should keep old name and behaviour of `ble_store_util_unpair_oldest_peer` - store APIs should just take care of storage and not use GAP. we can introduce GAP API to unpair oldest device instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services