You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/23 21:47:46 UTC
[GitHub] [solr] jebnix opened a new pull request, #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
jebnix opened a new pull request, #1114:
URL: https://github.com/apache/solr/pull/1114
…lain the relevancy of docker-networking
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
The Docker networking page seems to have a pretty old description. While this page is still relevant (mainly for local development), it is important to link Solr Operator to the subject. In general, it seems like a pretty blog kind of a page, therefore I've also removed the "I" and "I'll" words, and replaced them with "We" and "We'll" which seems more professional.
# Solution
described
# Tests
No
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Link Solr Operator for learning on Solr in Kubernetes, and better exp… [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #1114:
URL: https://github.com/apache/solr/pull/1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Link Solr Operator for learning on Solr in Kubernetes, and better exp… [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1962415592
Let me try to land this first, then you follow on with those improvements, and I’m sure many more will follow too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1289735161
I feel that the entire "Solr in Docker" content needs a rewrite. It was dumped into the refguide, but was not initially written for the refguide.
Personally I have never used the `solr-precreate` script or other custom scripts of the image, probably because I no longer maintain any standalone clusters, only Cloud. But that may be my preference. If those scripts are frequently used, they should definitely be described in the refguide.
However, the networking page is a way too detailed and hacky workarounds trying to make ZK run in a cluster in prod. I cannot say it is something I'd recommend to a client, so let's point them to the Operator, and perhaps some 3rd party maintained way of running ZK standalone in Docker for those with such needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1294522253
Maybe the gist of the networking page can be summarized as “Running distributed Zookeeper requires stable host names and IP addresses. Although possible, we discourage rolling your own zookeeper cluster in Docker. Dev/test instances can use a single node.”
Maybe we can link to somewhere in the zookeeper project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Link Solr Operator for learning on Solr in Kubernetes, and better exp… [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1951363457
I pushed some changes
* Remove docker-networking page
* Replace the FAQ bullet about cluster and zk, with a few paragraphs linking to Solr Operator and Zookeeper docker
* Removed FAQ advice on using `--link` between containers as it is definitely not a good advice anymore
I plan to merge this next week if no objections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1289441127
What about removing the entire page https://solr.apache.org/guide/solr/latest/deployment-guide/docker-networking.html?
And add a new page "Solr in Kubernetes" which alongside or below "Solr in Docker", as a very short introduction to the subject and then a link to the Solr-operator project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Link Solr Operator for learning on Solr in Kubernetes, and better exp… [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1962415972
Sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Link Solr Operator for learning on Solr in Kubernetes, and better exp… [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1962412594
@janhoy I was looking at the `solr-in-docker.adoc` page from the perspective of making sure the use of the `solr post` tool was working, and I noticed a lot of glitches..... Would it make sense for me to push my fixes (since some overlap witht his one) to this PR instead of making my own... For example, I found the same issues in the example `docker-compose.yml` file...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Link Solr Operator for learning on Solr in Kubernetes, and better exp… [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1951403061
This looks much nicer... Does this also cover some of the other patches that @jebnix provided? Thanks @janhoy for taking up some of these old PR's!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
jebnix commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1288208769
@epugh @janhoy I'm thinking whether we should [migrate this blog post](https://lucidworks.com/post/running-solr-on-kubernetes-part-1/) into a page of its own (some sort of "Solr in Kubernetes" page with general tips), or whether the Solr Operator project is enough.
After all there are people who'll use Kubernetes without the Operator...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
jebnix commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1292542225
@HoustonPutman I don't understand if you're voting for removing the page since you've said
> but we should keep the docs around as long as the scripts are still included
If you both agree to remove the page I'll add this to the PR. I'll also add to this PR the `Solr in Kubernetes` page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Link Solr Operator for learning on Solr in Kubernetes, and better exp… [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1951419793
> This looks much nicer... Does this also cover some of the other patches that @jebnix provided?
This is mainly related to running zookeeper and the cloud paragraph.
See #2277 for more cleanup of faq file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1290674365
> I feel that the entire "Solr in Docker" content needs a rewrite. It was dumped into the refguide, but was not initially written for the refguide.
Completely agree. I dumped it because rewriting it at the time would have been too much work on top of migrating everything else. But it really needs to be fixed up or just redone entirely.
> Personally I have never used the `solr-precreate` script or other custom scripts of the image, probably because I no longer maintain any standalone clusters, only Cloud. But that may be my preference. If those scripts are frequently used, they should definitely be described in the refguide.
I don't either, but we should keep the docs around as long as the scripts are still included.
> However, the networking page is a way too detailed and hacky workarounds trying to make ZK run in a cluster in prod. I cannot say it is something I'd recommend to a client, so let's point them to the Operator, and perhaps some 3rd party maintained way of running ZK standalone in Docker for those with such needs.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
jebnix commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1289682417
@janhoy Great idea. I'll work on adding this page to this PR. I'll use this [blog post ](https://lucidworks.com/post/running-solr-on-kubernetes-part-1/)as a heavy inspiration.
I'm not so sure about removing the docker networking. Maybe that can stay for local development inspiration. Anyway, that's your call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Link Solr Operator for learning on Solr in Kubernetes, and better exp… [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1951349002
The changes in this pr is an improvement in itself so perhaps merge it and the embark on a rewrite later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1381864895
Looks like this PR lost some steam. It is not my intention to shoot down suggestions - a cleanup of this content is definitely needed! I'd opt for shortening it down rather than adding more content though.. Feel free to sketch out an outline of the changes you plan to do after the discussions above. I'd love to review a PR with some of this cleanup!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
jebnix commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1368509088
@janhoy What link exactly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1368552097
> @janhoy What link exactly?
I'd just link to https://hub.docker.com/_/zookeeper and let users turn to the Zookeeper project for any support on how to make replicated Zookeeper work in plain Docker, Docker Swarm or any other orchestrator other than Kubernetes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Link Solr Operator for learning on Solr in Kubernetes, and better exp… [solr]
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1114:
URL: https://github.com/apache/solr/pull/1114#issuecomment-1964805248
Sorry, I was out on vacation. Thanks for finishing this up and seeing it through!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org