You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/04/30 08:29:20 UTC
[GitHub] [mynewt-newt] michal-narajowski opened a new pull request #397: Add include_dirs setting to syscfg
michal-narajowski opened a new pull request #397:
URL: https://github.com/apache/mynewt-newt/pull/397
Allows to specify directories to include in an external SDK
that does not follow the convention used by Newt of putting
everything under "src/ext/".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newt] michal-narajowski commented on a change in pull request #397: Add include_dirs setting to syscfg
Posted by GitBox <gi...@apache.org>.
michal-narajowski commented on a change in pull request #397:
URL: https://github.com/apache/mynewt-newt/pull/397#discussion_r419240114
##########
File path: newt/builder/buildpackage.go
##########
@@ -251,6 +252,16 @@ func (bpkg *BuildPackage) publicIncludeDirs(bspPkg *pkg.BspPackage) []string {
sdkIncls := bpkg.findSdkIncludes()
incls = append(incls, sdkIncls...)
+
+ settings := b.cfg.AllSettingsForLpkg(bpkg.rpkg.Lpkg)
+
+ inclDirs, err := bpkg.rpkg.Lpkg.PkgY.GetValStringSlice(
+ "pkg.include_dirs", settings)
+ util.OneTimeWarningError(err)
+
+ for _, src := range inclDirs {
Review comment:
Oops, I missed that. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #397: Add include_dirs setting to syscfg
Posted by GitBox <gi...@apache.org>.
ccollins476ad commented on a change in pull request #397:
URL: https://github.com/apache/mynewt-newt/pull/397#discussion_r418196584
##########
File path: newt/builder/buildpackage.go
##########
@@ -251,6 +252,16 @@ func (bpkg *BuildPackage) publicIncludeDirs(bspPkg *pkg.BspPackage) []string {
sdkIncls := bpkg.findSdkIncludes()
incls = append(incls, sdkIncls...)
+
+ settings := b.cfg.AllSettingsForLpkg(bpkg.rpkg.Lpkg)
+
+ inclDirs, err := bpkg.rpkg.Lpkg.PkgY.GetValStringSlice(
+ "pkg.include_dirs", settings)
+ util.OneTimeWarningError(err)
+
+ for _, src := range inclDirs {
Review comment:
nitpick: `src` is an odd name to use here. Something like `dir` feels more appropriate to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org