You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/23 12:35:53 UTC

[GitHub] larroy commented on a change in pull request #10202: [MXNET-131] Refine build.py, misc fixes, tweak commandline, add help

larroy commented on a change in pull request #10202: [MXNET-131] Refine build.py, misc fixes, tweak commandline, add help
URL: https://github.com/apache/incubator-mxnet/pull/10202#discussion_r176720887
 
 

 ##########
 File path: ci/build.py
 ##########
 @@ -48,7 +49,7 @@ def get_platforms(path: Optional[str]="docker"):
     return platforms
 
 
-def get_docker_tag(platform: str) -> None:
+def get_docker_tag(platform: str) -> str:
 
 Review comment:
   it's run by python3 only

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services