You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "my-vegetable-has-exploded (via GitHub)" <gi...@apache.org> on 2023/12/10 10:52:09 UTC

[PR] feat: Support quote and escape in Csv WriterBuilder [arrow-rs]

my-vegetable-has-exploded opened a new pull request, #5196:
URL: https://github.com/apache/arrow-rs/pull/5196

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #5146
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   add some option for writebuiler
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Support quote and escape in Csv WriterBuilder [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5196:
URL: https://github.com/apache/arrow-rs/pull/5196#discussion_r1424337619


##########
arrow-csv/src/writer.rs:
##########
@@ -193,6 +193,12 @@ pub struct WriterBuilder {
     delimiter: u8,
     /// Whether to write column names as file headers. Defaults to `true`
     has_header: bool,
+    /// Optional quote character. Defaults to `b'"'`
+    quote: u8,
+    /// Optional escape character. Defaults to `b'\\'`
+    escape: u8,

Review Comment:
   I think this needs to be an option, that is by default None. Otherwise as written this enables escapes by default, which we definitely do not want?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Support quote and escape in Csv WriterBuilder [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #5196:
URL: https://github.com/apache/arrow-rs/pull/5196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Support quote and escape in Csv WriterBuilder [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5196:
URL: https://github.com/apache/arrow-rs/pull/5196#discussion_r1424337619


##########
arrow-csv/src/writer.rs:
##########
@@ -193,6 +193,12 @@ pub struct WriterBuilder {
     delimiter: u8,
     /// Whether to write column names as file headers. Defaults to `true`
     has_header: bool,
+    /// Optional quote character. Defaults to `b'"'`
+    quote: u8,
+    /// Optional escape character. Defaults to `b'\\'`
+    escape: u8,

Review Comment:
   I think this needs to be an option, that is by default None. Otherwise as written this enables escapes by default, which we definitely do not want?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Support quote and escape in Csv WriterBuilder [arrow-rs]

Posted by "my-vegetable-has-exploded (via GitHub)" <gi...@apache.org>.
my-vegetable-has-exploded commented on PR #5196:
URL: https://github.com/apache/arrow-rs/pull/5196#issuecomment-1853055962

   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org