You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/05 08:43:24 UTC

[GitHub] [tvm] hzfan commented on a change in pull request #7045: [Arith] Simplify cast

hzfan commented on a change in pull request #7045:
URL: https://github.com/apache/tvm/pull/7045#discussion_r551789221



##########
File path: src/arith/canonical_simplify.cc
##########
@@ -77,6 +77,25 @@ inline PrimExpr DivImpl(PrimExpr a, PrimExpr b, DivMode mode) {
   }
 }
 
+bool CheckCastImpl(DataType dtype, PrimExpr value, Analyzer* analyzer) {

Review comment:
       I guess CastIsSafe seems better, since it checks both upcast and downcast




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org