You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/08 18:16:51 UTC

Review Request 56455: ATLAS-1540: fixed unit test failures in TestEntityREST

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56455/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1540
    https://issues.apache.org/jira/browse/ATLAS-1540


Repository: atlas


Description
-------

fixed unit test failures in TestEntityREST


Diffs
-----

  server-api/src/main/java/org/apache/atlas/RequestContext.java 09cdc37 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 354722f 

Diff: https://reviews.apache.org/r/56455/diff/


Testing
-------

- verified that the unit tests pass successfully


Thanks,

Madhan Neethiraj

Re: Review Request 56455: ATLAS-1540: fixed unit test failures in TestEntityREST

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56455/#review164739
-----------------------------------------------------------


Ship it!




Ship It!

- Apoorv Naik


On Feb. 8, 2017, 6:16 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56455/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 6:16 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1540
>     https://issues.apache.org/jira/browse/ATLAS-1540
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> fixed unit test failures in TestEntityREST
> 
> 
> Diffs
> -----
> 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java 09cdc37 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 354722f 
> 
> Diff: https://reviews.apache.org/r/56455/diff/
> 
> 
> Testing
> -------
> 
> - verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56455: ATLAS-1540: fixed unit test failures in TestEntityREST

Posted by Sarath Subramanian <sa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56455/#review164733
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Feb. 8, 2017, 10:16 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56455/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 10:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1540
>     https://issues.apache.org/jira/browse/ATLAS-1540
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> fixed unit test failures in TestEntityREST
> 
> 
> Diffs
> -----
> 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java 09cdc37 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 354722f 
> 
> Diff: https://reviews.apache.org/r/56455/diff/
> 
> 
> Testing
> -------
> 
> - verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56455: ATLAS-1540: fixed unit test failures in TestEntityREST

Posted by Sarath Subramanian <sa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56455/#review164735
-----------------------------------------------------------




server-api/src/main/java/org/apache/atlas/RequestContext.java (line 100)
<https://reviews.apache.org/r/56455/#comment236493>

    empty check - MapUtils.isNotEmpty(instance.entityCache)


- Sarath Subramanian


On Feb. 8, 2017, 10:16 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56455/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 10:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1540
>     https://issues.apache.org/jira/browse/ATLAS-1540
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> fixed unit test failures in TestEntityREST
> 
> 
> Diffs
> -----
> 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java 09cdc37 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 354722f 
> 
> Diff: https://reviews.apache.org/r/56455/diff/
> 
> 
> Testing
> -------
> 
> - verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56455: ATLAS-1540: fixed unit test failures in TestEntityREST

Posted by Sarath Subramanian <sa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56455/#review164730
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java (line 164)
<https://reviews.apache.org/r/56455/#comment236484>

    could consolidate lines 161-164 with createTestEntity();


- Sarath Subramanian


On Feb. 8, 2017, 10:16 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56455/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 10:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1540
>     https://issues.apache.org/jira/browse/ATLAS-1540
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> fixed unit test failures in TestEntityREST
> 
> 
> Diffs
> -----
> 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java 09cdc37 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 354722f 
> 
> Diff: https://reviews.apache.org/r/56455/diff/
> 
> 
> Testing
> -------
> 
> - verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56455: ATLAS-1540: fixed unit test failures in TestEntityREST

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56455/#review164741
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java (line 164)
<https://reviews.apache.org/r/56455/#comment236497>

    This test does not change this.dbEntity; hence didn't call createTestEntity() - which might impact other tests.


- Madhan Neethiraj


On Feb. 8, 2017, 6:16 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56455/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 6:16 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1540
>     https://issues.apache.org/jira/browse/ATLAS-1540
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> fixed unit test failures in TestEntityREST
> 
> 
> Diffs
> -----
> 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java 09cdc37 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 354722f 
> 
> Diff: https://reviews.apache.org/r/56455/diff/
> 
> 
> Testing
> -------
> 
> - verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>