You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/20 13:52:39 UTC
[GitHub] [incubator-hudi] pratyakshsharma opened a new pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
pratyakshsharma opened a new pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648
…dKeyGenerator
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648#discussion_r429230492
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/keygen/TimestampBasedKeyGenerator.java
##########
@@ -53,44 +56,74 @@
private final TimestampType timestampType;
- private SimpleDateFormat inputDateFormat;
-
private final String outputDateFormat;
+ private DateTimeFormatter inputFormatter;
+ private final String configInputDateFormatList;
+ private final String configInputDateFormatDelimiter;
// TimeZone detailed settings reference
// https://docs.oracle.com/javase/8/docs/api/java/util/TimeZone.html
- private final TimeZone timeZone;
+ private final DateTimeZone inputDateTimeZone;
+ private final DateTimeZone outputDateTimeZone;
/**
* Supported configs.
*/
static class Config {
// One value from TimestampType above
- private static final String TIMESTAMP_TYPE_FIELD_PROP = "hoodie.deltastreamer.keygen.timebased.timestamp.type";
- private static final String INPUT_TIME_UNIT =
+ public static final String TIMESTAMP_TYPE_FIELD_PROP = "hoodie.deltastreamer.keygen.timebased.timestamp.type";
+ public static final String INPUT_TIME_UNIT =
"hoodie.deltastreamer.keygen.timebased.timestamp.scalar.time.unit";
- private static final String TIMESTAMP_INPUT_DATE_FORMAT_PROP =
+ //This prop can now accept list of input date formats.
+ public static final String TIMESTAMP_INPUT_DATE_FORMAT_PROP =
"hoodie.deltastreamer.keygen.timebased.input.dateformat";
- private static final String TIMESTAMP_OUTPUT_DATE_FORMAT_PROP =
+ public static final String TIMESTAMP_INPUT_DATE_FORMAT_LIST_DELIMITER_REGEX_PROP = "hoodie.deltastreamer.keygen.timebased.input.dateformatlistdelimiterregex";
Review comment:
can we add dots (".") between words. hoodie.deltastreamer.keygen.timebased.input.dateformat.list.delimiter.regex
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/keygen/TimestampBasedKeyGenerator.java
##########
@@ -53,44 +56,74 @@
private final TimestampType timestampType;
- private SimpleDateFormat inputDateFormat;
-
private final String outputDateFormat;
+ private DateTimeFormatter inputFormatter;
+ private final String configInputDateFormatList;
+ private final String configInputDateFormatDelimiter;
// TimeZone detailed settings reference
// https://docs.oracle.com/javase/8/docs/api/java/util/TimeZone.html
- private final TimeZone timeZone;
+ private final DateTimeZone inputDateTimeZone;
+ private final DateTimeZone outputDateTimeZone;
/**
* Supported configs.
*/
static class Config {
// One value from TimestampType above
- private static final String TIMESTAMP_TYPE_FIELD_PROP = "hoodie.deltastreamer.keygen.timebased.timestamp.type";
- private static final String INPUT_TIME_UNIT =
+ public static final String TIMESTAMP_TYPE_FIELD_PROP = "hoodie.deltastreamer.keygen.timebased.timestamp.type";
Review comment:
why public? package private isn't sufficient?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] pratyakshsharma commented on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-632611762
> @pratyakshsharma : was this patch already reviewed as part of #1597? or do I need to review it from scratch
The changes in https://github.com/apache/incubator-hudi/pull/1597 were done by creating a separate class (MultiFormatTimestampBasedKeyGenerator). In this PR, I have tried to include all the changes in already existing TimestampBasedKeyGenerator class. So you need to take a look from scratch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-631889483
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=h1) Report
> Merging [#1648](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/244d47494e2d4d5b3ca60e460e1feb9351fb8e69&el=desc) will **increase** coverage by `1.48%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1648 +/- ##
============================================
+ Coverage 16.60% 18.09% +1.48%
- Complexity 800 856 +56
============================================
Files 344 351 +7
Lines 15172 15436 +264
Branches 1512 1539 +27
============================================
+ Hits 2520 2793 +273
+ Misses 12320 12286 -34
- Partials 332 357 +25
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/hudi/DataSourceUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9EYXRhU291cmNlVXRpbHMuamF2YQ==) | `31.37% <0.00%> (-0.96%)` | `0.00 <0.00> (ø)` | |
| [...e/hudi/exception/HoodieDeltaStreamerException.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9leGNlcHRpb24vSG9vZGllRGVsdGFTdHJlYW1lckV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/hudi/keygen/TimestampBasedKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vVGltZXN0YW1wQmFzZWRLZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vcGFyc2VyL0hvb2RpZURhdGVUaW1lUGFyc2VySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVdyaXRlQ29uZmlnLmphdmE=) | `40.07% <0.00%> (-2.19%)` | `48.00% <0.00%> (ø%)` | |
| [...ain/java/org/apache/hudi/avro/HoodieAvroUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9Ib29kaWVBdnJvVXRpbHMuamF2YQ==) | `48.09% <0.00%> (-1.91%)` | `22.00% <0.00%> (ø%)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
| [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...g/apache/hudi/metrics/datadog/DatadogReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9kYXRhZG9nL0RhdGFkb2dSZXBvcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apache/hudi/metrics/datadog/DatadogHttpClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9kYXRhZG9nL0RhdGFkb2dIdHRwQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [23 more](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=footer). Last update [244d474...85db4a0](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-631889483
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=h1) Report
> Merging [#1648](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/244d47494e2d4d5b3ca60e460e1feb9351fb8e69&el=desc) will **increase** coverage by `1.48%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1648 +/- ##
============================================
+ Coverage 16.60% 18.09% +1.48%
- Complexity 800 856 +56
============================================
Files 344 351 +7
Lines 15172 15436 +264
Branches 1512 1539 +27
============================================
+ Hits 2520 2793 +273
+ Misses 12320 12286 -34
- Partials 332 357 +25
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/hudi/DataSourceUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9EYXRhU291cmNlVXRpbHMuamF2YQ==) | `31.37% <0.00%> (-0.96%)` | `0.00 <0.00> (ø)` | |
| [...e/hudi/exception/HoodieDeltaStreamerException.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9leGNlcHRpb24vSG9vZGllRGVsdGFTdHJlYW1lckV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/hudi/keygen/TimestampBasedKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vVGltZXN0YW1wQmFzZWRLZXlHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/hudi/keygen/parser/HoodieDateTimeParserImpl.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vcGFyc2VyL0hvb2RpZURhdGVUaW1lUGFyc2VySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVdyaXRlQ29uZmlnLmphdmE=) | `40.07% <0.00%> (-2.19%)` | `48.00% <0.00%> (ø%)` | |
| [...ain/java/org/apache/hudi/avro/HoodieAvroUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9Ib29kaWVBdnJvVXRpbHMuamF2YQ==) | `48.09% <0.00%> (-1.91%)` | `22.00% <0.00%> (ø%)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
| [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...apache/hudi/metrics/datadog/DatadogHttpClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9kYXRhZG9nL0RhdGFkb2dIdHRwQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [23 more](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=footer). Last update [244d474...85db4a0](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] nsivabalan commented on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-632392315
@pratyakshsharma : was this patch already reviewed as part of[ #1597](https://github.com/apache/incubator-hudi/pull/1597)? or do I need to review it from scratch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] pratyakshsharma commented on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-631488125
@nsivabalan Raised a separate PR for https://github.com/apache/incubator-hudi/pull/1597. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-631889483
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=h1) Report
> Merging [#1648](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/244d47494e2d4d5b3ca60e460e1feb9351fb8e69&el=desc) will **increase** coverage by `1.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1648 +/- ##
============================================
+ Coverage 16.60% 18.33% +1.72%
- Complexity 800 855 +55
============================================
Files 344 344
Lines 15172 15167 -5
Branches 1512 1512
============================================
+ Hits 2520 2781 +261
+ Misses 12320 12033 -287
- Partials 332 353 +21
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/hudi/avro/HoodieAvroUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9Ib29kaWVBdnJvVXRpbHMuamF2YQ==) | `48.09% <0.00%> (-1.91%)` | `22.00% <0.00%> (ø%)` | |
| [...le/view/IncrementalTimelineSyncFileSystemView.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSW5jcmVtZW50YWxUaW1lbGluZVN5bmNGaWxlU3lzdGVtVmlldy5qYXZh) | `4.51% <0.00%> (+0.56%)` | `4.00% <0.00%> (+1.00%)` | |
| [...common/table/view/AbstractTableFileSystemView.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvQWJzdHJhY3RUYWJsZUZpbGVTeXN0ZW1WaWV3LmphdmE=) | `8.59% <0.00%> (+2.34%)` | `6.00% <0.00%> (+1.00%)` | |
| [...i/common/table/timeline/HoodieDefaultTimeline.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL0hvb2RpZURlZmF1bHRUaW1lbGluZS5qYXZh) | `52.30% <0.00%> (+4.61%)` | `28.00% <0.00%> (+4.00%)` | |
| [.../main/java/org/apache/hudi/common/util/Option.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvT3B0aW9uLmphdmE=) | `51.35% <0.00%> (+5.40%)` | `18.00% <0.00%> (+1.00%)` | |
| [...udi/timeline/service/handlers/BaseFileHandler.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvaGFuZGxlcnMvQmFzZUZpbGVIYW5kbGVyLmphdmE=) | `11.11% <0.00%> (+11.11%)` | `1.00% <0.00%> (+1.00%)` | |
| [...common/table/view/PriorityBasedFileSystemView.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvUHJpb3JpdHlCYXNlZEZpbGVTeXN0ZW1WaWV3LmphdmE=) | `11.94% <0.00%> (+11.94%)` | `4.00% <0.00%> (+4.00%)` | |
| [...i/common/table/view/HoodieTableFileSystemView.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `37.93% <0.00%> (+13.79%)` | `9.00% <0.00%> (+2.00%)` | |
| [...common/table/view/FileSystemViewStorageConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvRmlsZVN5c3RlbVZpZXdTdG9yYWdlQ29uZmlnLmphdmE=) | `63.49% <0.00%> (+14.28%)` | `8.00% <0.00%> (+3.00%)` | |
| [...a/org/apache/hudi/client/AbstractHoodieClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllQ2xpZW50LmphdmE=) | `65.78% <0.00%> (+18.42%)` | `6.00% <0.00%> (ø%)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=footer). Last update [244d474...45c57f7](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] nsivabalan commented on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-632683547
Also, for book-keeping purposes, can you fix the description of this patch. I guess you missed to copy from the original.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-commenter commented on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1648:
URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-631889483
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=h1) Report
> Merging [#1648](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/244d47494e2d4d5b3ca60e460e1feb9351fb8e69&el=desc) will **increase** coverage by `1.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1648 +/- ##
============================================
+ Coverage 16.60% 18.33% +1.72%
- Complexity 800 855 +55
============================================
Files 344 344
Lines 15172 15167 -5
Branches 1512 1512
============================================
+ Hits 2520 2781 +261
+ Misses 12320 12033 -287
- Partials 332 353 +21
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/hudi/avro/HoodieAvroUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvYXZyby9Ib29kaWVBdnJvVXRpbHMuamF2YQ==) | `48.09% <0.00%> (-1.91%)` | `22.00% <0.00%> (ø%)` | |
| [...le/view/IncrementalTimelineSyncFileSystemView.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSW5jcmVtZW50YWxUaW1lbGluZVN5bmNGaWxlU3lzdGVtVmlldy5qYXZh) | `4.51% <0.00%> (+0.56%)` | `4.00% <0.00%> (+1.00%)` | |
| [...common/table/view/AbstractTableFileSystemView.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvQWJzdHJhY3RUYWJsZUZpbGVTeXN0ZW1WaWV3LmphdmE=) | `8.59% <0.00%> (+2.34%)` | `6.00% <0.00%> (+1.00%)` | |
| [...i/common/table/timeline/HoodieDefaultTimeline.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL0hvb2RpZURlZmF1bHRUaW1lbGluZS5qYXZh) | `52.30% <0.00%> (+4.61%)` | `28.00% <0.00%> (+4.00%)` | |
| [.../main/java/org/apache/hudi/common/util/Option.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvT3B0aW9uLmphdmE=) | `51.35% <0.00%> (+5.40%)` | `18.00% <0.00%> (+1.00%)` | |
| [...udi/timeline/service/handlers/BaseFileHandler.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvaGFuZGxlcnMvQmFzZUZpbGVIYW5kbGVyLmphdmE=) | `11.11% <0.00%> (+11.11%)` | `1.00% <0.00%> (+1.00%)` | |
| [...common/table/view/PriorityBasedFileSystemView.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvUHJpb3JpdHlCYXNlZEZpbGVTeXN0ZW1WaWV3LmphdmE=) | `11.94% <0.00%> (+11.94%)` | `4.00% <0.00%> (+4.00%)` | |
| [...i/common/table/view/HoodieTableFileSystemView.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `37.93% <0.00%> (+13.79%)` | `9.00% <0.00%> (+2.00%)` | |
| [...common/table/view/FileSystemViewStorageConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvRmlsZVN5c3RlbVZpZXdTdG9yYWdlQ29uZmlnLmphdmE=) | `63.49% <0.00%> (+14.28%)` | `8.00% <0.00%> (+3.00%)` | |
| [...a/org/apache/hudi/client/AbstractHoodieClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllQ2xpZW50LmphdmE=) | `65.78% <0.00%> (+18.42%)` | `6.00% <0.00%> (ø%)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-hudi/pull/1648/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=footer). Last update [244d474...45c57f7](https://codecov.io/gh/apache/incubator-hudi/pull/1648?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org