You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2016/09/07 05:46:07 UTC
[jclouds/jclouds-cli] Misc cleanup (#31)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-cli/pull/31
-- Commit Summary --
* Align the startup.properties file with Karaf 2.3.11
* Remove a non-existent feature from the list of features to boot on startup
* Tentatively remove Guava from the system deps for the distribution
-- File Changes --
M assembly/src/main/assembly/unix.xml (4)
M assembly/src/main/assembly/win.xml (4)
M assembly/src/main/filtered-resources/etc/org.apache.karaf.features.cfg (2)
M assembly/src/main/filtered-resources/etc/startup.properties (7)
M project/pom.xml (2)
-- Patch Links --
https://github.com/jclouds/jclouds-cli/pull/31.patch
https://github.com/jclouds/jclouds-cli/pull/31.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Andrew Phillips <no...@github.com>.
> Which is the status of this PR?
I'd still like to merge it; I think we were hoping someone else would get a chance to verify that this doesn't break anything...
Thanks for the ping, @nacx!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31#issuecomment-256085392
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Andrew Phillips <no...@github.com>.
Closed #31.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31#event-837828686
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Ignasi Barrera <no...@github.com>.
Yeah, let's merge it!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31#issuecomment-256392542
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Andrew Phillips <no...@github.com>.
> I've also successfully tested basic operations with Azure ARM
Good to merge and perhaps call out testing of the CLI as a task for verifiers for the 2.0.0. release?
Thanks for trying this out, @nacx!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31#issuecomment-256386363
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Ignasi Barrera <no...@github.com>.
I've also successfully tested basic operations with Azure ARM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31#issuecomment-256365123
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Andrew Phillips <no...@github.com>.
> @@ -39,11 +39,12 @@ org/apache/aries/blueprint/org.apache.aries.blueprint.api/${aries.blueprint.api.
> org/apache/aries/blueprint/org.apache.aries.blueprint.core/${aries.blueprint.core.version}/org.apache.aries.blueprint.core-${aries.blueprint.core.version}.jar=20
> org/apache/aries/blueprint/org.apache.aries.blueprint.cm/${aries.blueprint.cm.version}/org.apache.aries.blueprint.cm-${aries.blueprint.cm.version}.jar=20
>
> -org/apache/karaf/shell/org.apache.karaf.shell.console/${karaf.version}/org.apache.karaf.shell.console-${karaf.version}.jar=29
> +org/apache/karaf/shell/org.apache.karaf.shell.console/${karaf.version}/org.apache.karaf.shell.console-${karaf.version}.jar=25
See https://github.com/apache/karaf/blob/karaf-2.3.11/assemblies/apache-karaf/src/main/filtered-resources/minimal/startup.properties for the motivation for these changes
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31/files/0061346d112da919d20fe52c51973c6f46ef6ec2#r77762880
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Andrew Gaul <no...@github.com>.
I successfully tested a few operations with aws-s3.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31#issuecomment-256178245
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Ignasi Barrera <no...@github.com>.
@demobox quick reminder :) Which is the status of this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31#issuecomment-256039710
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Andrew Phillips <no...@github.com>.
> \ No newline at end of file
> +featuresBoot=jclouds-chef,jclouds-aws-ec2,jclouds-aws-s3
`config:list` and other commands still seem to be present
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31/files/0061346d112da919d20fe52c51973c6f46ef6ec2..bc003de96a72d889203a0b043b03a7161f93d7cb#r77762920
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Andrew Phillips <no...@github.com>.
> @@ -137,13 +137,13 @@
> </includes>
> <useTransitiveDependencies>false</useTransitiveDependencies>
> </dependencySet>
> - <dependencySet>
> + <!--dependencySet>
> I've tested this on top of all the latest changes and it works fine!
Nice - thanks for testing! Will remove those "properly", in that case
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31/files/bc003de96a72d889203a0b043b03a7161f93d7cb..7dba96d54e893b61716fcaa4d90557e98321ba05#r77951240
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -137,13 +137,13 @@
> </includes>
> <useTransitiveDependencies>false</useTransitiveDependencies>
> </dependencySet>
> - <dependencySet>
> + <!--dependencySet>
I've tested this on top of all the latest changes and it works fine!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31/files/bc003de96a72d889203a0b043b03a7161f93d7cb..7dba96d54e893b61716fcaa4d90557e98321ba05#r77895055
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Andrew Phillips <no...@github.com>.
> @@ -137,13 +137,13 @@
> </includes>
> <useTransitiveDependencies>false</useTransitiveDependencies>
> </dependencySet>
> - <dependencySet>
> + <!--dependencySet>
These changes look like they're working, but still waiting for validation. The "proper" commit would remove these rather than commenting them out
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31/files/bc003de96a72d889203a0b043b03a7161f93d7cb..7dba96d54e893b61716fcaa4d90557e98321ba05#r77762835
Re: [jclouds/jclouds-cli] Misc cleanup (#31)
Posted by Andrew Phillips <no...@github.com>.
> Yeah, let's merge it!
;-) Merge to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-cli.git;a=commit;h=cf1d92f1cac00bb66664df54c15bd91b09fbae68)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/31#issuecomment-256498369