You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2011/03/03 21:55:37 UTC
[jira] Created: (HDFS-1717) Federation: FSDataset volumeMap access
is not correctly synchronized
Federation: FSDataset volumeMap access is not correctly synchronized
---------------------------------------------------------------------
Key: HDFS-1717
URL: https://issues.apache.org/jira/browse/HDFS-1717
Project: Hadoop HDFS
Issue Type: Sub-task
Components: data-node
Affects Versions: Federation Branch
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Fix For: Federation Branch
FSDataset volumeMap access has several issues:
# Access to it is not synchronized all the time, using FSDataset.this as lock, as expected.
# It is synchronized using different locks.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1717) Federation: FSDataset volumeMap access
is not correctly synchronized
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-1717:
----------------------------------
Attachment: HDFS-1717.2.patch
Updated patch.
> Federation: FSDataset volumeMap access is not correctly synchronized
> ---------------------------------------------------------------------
>
> Key: HDFS-1717
> URL: https://issues.apache.org/jira/browse/HDFS-1717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1717.1.patch, HDFS-1717.2.patch, HDFS-1717.patch
>
>
> FSDataset volumeMap access has several issues:
> # Access to it is not synchronized all the time, using FSDataset.this as lock, as expected.
> # It is synchronized using different locks.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1717) Federation: FSDataset volumeMap access
is not correctly synchronized
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-1717:
----------------------------------
Attachment: HDFS-1717.1.patch
Updated patch for federation branch.
> Federation: FSDataset volumeMap access is not correctly synchronized
> ---------------------------------------------------------------------
>
> Key: HDFS-1717
> URL: https://issues.apache.org/jira/browse/HDFS-1717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1717.1.patch, HDFS-1717.patch
>
>
> FSDataset volumeMap access has several issues:
> # Access to it is not synchronized all the time, using FSDataset.this as lock, as expected.
> # It is synchronized using different locks.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1717) Federation: FSDataset volumeMap
access is not correctly synchronized
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002213#comment-13002213 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1717:
----------------------------------------------
+1 patch looks good.
> Federation: FSDataset volumeMap access is not correctly synchronized
> ---------------------------------------------------------------------
>
> Key: HDFS-1717
> URL: https://issues.apache.org/jira/browse/HDFS-1717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1717.patch
>
>
> FSDataset volumeMap access has several issues:
> # Access to it is not synchronized all the time, using FSDataset.this as lock, as expected.
> # It is synchronized using different locks.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HDFS-1717) Federation: FSDataset volumeMap access
is not correctly synchronized
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas resolved HDFS-1717.
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
I committed the patch.
> Federation: FSDataset volumeMap access is not correctly synchronized
> ---------------------------------------------------------------------
>
> Key: HDFS-1717
> URL: https://issues.apache.org/jira/browse/HDFS-1717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1717.1.patch, HDFS-1717.2.patch, HDFS-1717.3.patch, HDFS-1717.patch
>
>
> FSDataset volumeMap access has several issues:
> # Access to it is not synchronized all the time, using FSDataset.this as lock, as expected.
> # It is synchronized using different locks.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1717) Federation: FSDataset volumeMap access
is not correctly synchronized
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-1717:
----------------------------------
Attachment: HDFS-1717.3.patch
Adding a change that was missed in previous version of the patch.
> Federation: FSDataset volumeMap access is not correctly synchronized
> ---------------------------------------------------------------------
>
> Key: HDFS-1717
> URL: https://issues.apache.org/jira/browse/HDFS-1717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1717.1.patch, HDFS-1717.2.patch, HDFS-1717.3.patch, HDFS-1717.patch
>
>
> FSDataset volumeMap access has several issues:
> # Access to it is not synchronized all the time, using FSDataset.this as lock, as expected.
> # It is synchronized using different locks.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1717) Federation: FSDataset volumeMap access
is not correctly synchronized
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-1717:
----------------------------------
Attachment: HDFS-1717.patch
In the attached patch:
- Access to FSDataset#volumeMap is always synchronized using FSDataset.this
- Some of the FSDataset members are made final.
> Federation: FSDataset volumeMap access is not correctly synchronized
> ---------------------------------------------------------------------
>
> Key: HDFS-1717
> URL: https://issues.apache.org/jira/browse/HDFS-1717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1717.patch
>
>
> FSDataset volumeMap access has several issues:
> # Access to it is not synchronized all the time, using FSDataset.this as lock, as expected.
> # It is synchronized using different locks.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1717) Federation: FSDataset volumeMap
access is not correctly synchronized
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002331#comment-13002331 ]
Suresh Srinivas commented on HDFS-1717:
---------------------------------------
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 6 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.8) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] -1 system test framework. The patch failed system test framework compile.
The -1 in system test framework is not related to this patch. It is not expected after merging trunk to federation branch.
> Federation: FSDataset volumeMap access is not correctly synchronized
> ---------------------------------------------------------------------
>
> Key: HDFS-1717
> URL: https://issues.apache.org/jira/browse/HDFS-1717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1717.1.patch, HDFS-1717.2.patch, HDFS-1717.patch
>
>
> FSDataset volumeMap access has several issues:
> # Access to it is not synchronized all the time, using FSDataset.this as lock, as expected.
> # It is synchronized using different locks.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1717) Federation: FSDataset volumeMap
access is not correctly synchronized
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002341#comment-13002341 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1717:
----------------------------------------------
+1 HDFS-1717.3.patch looks good
> Federation: FSDataset volumeMap access is not correctly synchronized
> ---------------------------------------------------------------------
>
> Key: HDFS-1717
> URL: https://issues.apache.org/jira/browse/HDFS-1717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1717.1.patch, HDFS-1717.2.patch, HDFS-1717.3.patch, HDFS-1717.patch
>
>
> FSDataset volumeMap access has several issues:
> # Access to it is not synchronized all the time, using FSDataset.this as lock, as expected.
> # It is synchronized using different locks.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira