You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by bu...@apache.org on 2009/03/27 15:00:17 UTC
DO NOT REPLY [Bug 46926] New: [PATCH] More control over
RasterizerTask output files
https://issues.apache.org/bugzilla/show_bug.cgi?id=46926
Summary: [PATCH] More control over RasterizerTask output files
Product: Batik
Version: 1.8
Platform: All
URL: http://www.nabble.com/-PATCH--More-control-over-Raster
izerTask-output-files-td22088264.html#a22088264
OS/Version: All
Status: NEW
Keywords: PatchAvailable
Severity: enhancement
Priority: P4
Component: SVG Rasterizer
AssignedTo: batik-dev@xmlgraphics.apache.org
ReportedBy: helder.magalhaes@gmail.com
Originally reported by Martin von Gagern.
I've created this report as the original mailing list thread (report's URL)
didn't get any follow up, to make sure this doesn't get lost, at least not
without a proper debate. :-)
The proposed patch is available through the mailing list post.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 46926] [PATCH] More control over RasterizerTask
output files
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46926
--- Comment #6 from Helder Magalhães <he...@gmail.com> 2009-04-30 14:15:25 PST ---
(In reply to comment #5)
> Created an attachment (id=23558)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23558) [details]
> Patch version 4
Seems like ready for (a deeper) review now. :-) Can a Batik committer evaluate
this and/or (potentially) delineate a list of actions/tests yet to be
addressed?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 46926] [PATCH] More control over RasterizerTask
output files
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46926
Martin von Gagern <Ma...@gmx.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Martin.vGagern@gmx.net
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 46926] [PATCH] More control over RasterizerTask
output files
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46926
--- Comment #4 from Helder Magalhães <he...@gmail.com> 2009-04-26 16:22:30 PST ---
(In reply to comment #3)
> Patch version 3
Nice to the patch improving. :-)
>From a quick look, without involving any testing, I only noticed a few
tab/space mix-up in indenting. As far as I know, Batik only uses spaces, so
please consider updating the patch. ;-)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 46926] [PATCH] More control over RasterizerTask
output files
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46926
Martin von Gagern <Ma...@gmx.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23422|0 |1
is obsolete| |
--- Comment #3 from Martin von Gagern <Ma...@gmx.net> 2009-04-22 07:22:14 PST ---
Created an attachment (id=23529)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23529)
Patch version 3
(In reply to comment #2)
> From the main "build.xml" file:
>
> If you are going to be doing development you may want to create a file
> called 'build.properties' with the line 'debug=on' in it. This will
> turn on the generation of debugging information when compiling Batik.
>
> I'm not sure if it would be a good idea to make this here also but, at least,
> creating a property "debug" and using 'debug="${debug}"' instead (for
> coherency with the main build file) looked like a good idea. :-)
Did that, and also loaded the build.properties from the batik root directory.
> Finally, I believe the patch should also address some documentation regarding
> the newly introduced features.
Sure. I finally found the time to write a few words about this.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 46926] [PATCH] More control over RasterizerTask
output files
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46926
--- Comment #7 from Martin von Gagern <Ma...@gmx.net> 2009-10-12 05:20:14 UTC ---
Ping? Please include this patch, or comment on how it needs to be improved.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 46926] [PATCH] More control over RasterizerTask
output files
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46926
Martin von Gagern <Ma...@gmx.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23529|0 |1
is obsolete| |
--- Comment #5 from Martin von Gagern <Ma...@gmx.net> 2009-04-28 07:13:09 PST ---
Created an attachment (id=23558)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23558)
Patch version 4
(In reply to comment #4)
> From a quick look, without involving any testing, I only noticed a few
> tab/space mix-up in indenting. As far as I know, Batik only uses spaces, so
> please consider updating the patch. ;-)
Considered and done.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 46926] [PATCH] More control over RasterizerTask
output files
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46926
--- Comment #1 from Martin von Gagern <Ma...@gmx.net> 2009-03-27 08:10:39 PST ---
Created an attachment (id=23422)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23422)
Patch version 2
To avoid one level of indirection, I'll attach my patch here.
I've also taken up Helder's vote for compatibility, and added a flatten
attribute defaulting to true.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 46926] [PATCH] More control over RasterizerTask
output files
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46926
--- Comment #2 from Helder Magalhães <he...@gmail.com> 2009-03-27 09:01:13 PST ---
(In reply to comment #1)
> Created an attachment (id=23422)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23422) [details]
> Patch version 2
- <javac srcdir="${src}" destdir="${build.classes}" />
+ <javac srcdir="${src}" destdir="${build.classes}" debug="true">
+ <classpath>
+ <pathelement location="../../classes"/>
+ <fileset dir="." includes="lib/**/*.jar"/>
+ </classpath>
+ </javac>
>From the main "build.xml" file:
If you are going to be doing development you may want to create a file
called 'build.properties' with the line 'debug=on' in it. This will
turn on the generation of debugging information when compiling Batik.
I'm not sure if it would be a good idea to make this here also but, at least,
creating a property "debug" and using 'debug="${debug}"' instead (for coherency
with the main build file) looked like a good idea. :-)
> I've also taken up Helder's vote for compatibility, and added a flatten
> attribute defaulting to true.
Great! :-) Not breaking existing work is, IMHO, a good approach in general.
;-)
Finally, I believe the patch should also address some documentation regarding
the newly introduced features. (The documentation source for that is
"rasterizer.xml" [1] which, after published, should appear at "rasterizer.html"
[2].
[1] documentation-sources/content/xdocs/tools/rasterizer.xml
[2] http://xmlgraphics.apache.org/batik/tools/rasterizer.html#task
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org