You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/31 20:58:27 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #11867: Added MetadataStore deleteRecursive operation

eolivelli commented on a change in pull request #11867:
URL: https://github.com/apache/pulsar/pull/11867#discussion_r699667948



##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataStore.java
##########
@@ -112,6 +112,15 @@
      */
     CompletableFuture<Void> delete(String path, Optional<Long> expectedVersion);
 
+    /**
+     * Delete a key-value pair and all the children nodes

Review comment:
       Shall we add a specification that in case of failure the result of the operation is undetermined?
   We are not using a single transaction in zk and so the deletion may be partial 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org