You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by rip-nsk <gi...@git.apache.org> on 2017/12/14 20:32:44 UTC
[GitHub] orc pull request #202: Orc-280: [C++] use Z_PREFIX if zlib requires it
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/202
Orc-280: [C++] use Z_PREFIX if zlib requires it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-280
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/202.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #202
----
commit ac4b75c2b7a9d324b831a850c8a1f75703ca2996
Author: rip-nsk <ri...@gmail.com>
Date: 2017-12-14T20:20:33Z
#define Z_PREFIX if zlib built with --zprefix
----
---
[GitHub] orc issue #202: Orc-280: [C++] use Z_PREFIX if zlib requires it
Posted by rip-nsk <gi...@git.apache.org>.
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/202
It is custom installation. In my environment I have to use prebuilt static "zprefixed" zlib.
But it is general case since custom zlib can be used via ZLIB_HOME.
---
[GitHub] orc pull request #202: Orc-280: [C++] use Z_PREFIX if zlib requires it
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/202
---
[GitHub] orc issue #202: Orc-280: [C++] use Z_PREFIX if zlib requires it
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/202
Which platforms need this? I assume it would only be needed when you are using the system zlib.
---
[GitHub] orc issue #202: Orc-280: [C++] use Z_PREFIX if zlib requires it
Posted by rip-nsk <gi...@git.apache.org>.
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/202
Any platform, if corresponding zlib used (by ZLIB_HOME) to build ORC.
---
[GitHub] orc issue #202: Orc-280: [C++] use Z_PREFIX if zlib requires it
Posted by rip-nsk <gi...@git.apache.org>.
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/202
linux clang build broken due to new version of compiler (5.0.0)
This is not related to proposed changes.
---
[GitHub] orc issue #202: Orc-280: [C++] use Z_PREFIX if zlib requires it
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/202
Do any of the platforms build their vendor zlib library with Z_PREFIX? Or is it just custom installations?
---