You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2013/08/10 14:27:41 UTC
svn commit: r1512672 -
/maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
Author: dennisl
Date: Sat Aug 10 12:27:41 2013
New Revision: 1512672
URL: http://svn.apache.org/r1512672
Log:
Add subversion keywords.
Modified:
maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java (contents, props changed)
Modified: maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java?rev=1512672&r1=1512671&r2=1512672&view=diff
==============================================================================
--- maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java (original)
+++ maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java Sat Aug 10 12:27:41 2013
@@ -31,7 +31,7 @@ import org.apache.maven.project.MavenPro
* A base class for all classes that implements signing of files.
*
* @author Dennis Lundberg
- * @version $Revision: 1.1 $ $Date: 2004/07/28 09:48:35 2013-08-10 14:10 $
+ * @version $Revision$ $Date$
* @since 1.5
*/
public abstract class AbstractGpgSigner
Propchange: maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
------------------------------------------------------------------------------
svn:keywords = Date Revision Author Id
Re: svn commit: r1512672 - /maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
Posted by sebb <se...@gmail.com>.
On 13 August 2013 18:53, Dennis Lundberg <de...@apache.org> wrote:
> Hi
>
> Yeah, that was my @home "new file template" that kicked in.
> I've removed the @version tags now.
@version is OK; just don't use $Date$.
However just noticed that the code uses @author.
The @author tag is deprecated in ASF code [1]. Briefly:
- ASF is about community, not individuals
- too difficult to maintain accurately
Credit should be given elsewhere, e.g. in pom developer or contributor sections.
[1] http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt
section 7 F
> On Tue, Aug 13, 2013 at 12:48 PM, sebb <se...@gmail.com> wrote:
>> On 10 August 2013 13:27, <de...@apache.org> wrote:
>>> Author: dennisl
>>> Date: Sat Aug 10 12:27:41 2013
>>> New Revision: 1512672
>>>
>>> URL: http://svn.apache.org/r1512672
>>> Log:
>>> Add subversion keywords.
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java (contents, props changed)
>>>
>>> Modified: maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
>>> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java?rev=1512672&r1=1512671&r2=1512672&view=diff
>>> ==============================================================================
>>> --- maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java (original)
>>> +++ maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java Sat Aug 10 12:27:41 2013
>>> @@ -31,7 +31,7 @@ import org.apache.maven.project.MavenPro
>>> * A base class for all classes that implements signing of files.
>>> *
>>> * @author Dennis Lundberg
>>> - * @version $Revision: 1.1 $ $Date: 2004/07/28 09:48:35 2013-08-10 14:10 $
>>> + * @version $Revision$ $Date$
>>
>> Date causes problems.
>> The value and format depends on the user's locale, so source archives
>> will vary depending on where they were created.
>>
>> If you really need a timestamp (why?), use $Id$ instead.
>>
>>> * @since 1.5
>>> */
>>> public abstract class AbstractGpgSigner
>>>
>>> Propchange: maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
>>> ------------------------------------------------------------------------------
>>> svn:keywords = Date Revision Author Id
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1512672 - /maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
Posted by Dennis Lundberg <de...@apache.org>.
Hi
Yeah, that was my @home "new file template" that kicked in.
I've removed the @version tags now.
On Tue, Aug 13, 2013 at 12:48 PM, sebb <se...@gmail.com> wrote:
> On 10 August 2013 13:27, <de...@apache.org> wrote:
>> Author: dennisl
>> Date: Sat Aug 10 12:27:41 2013
>> New Revision: 1512672
>>
>> URL: http://svn.apache.org/r1512672
>> Log:
>> Add subversion keywords.
>>
>> Modified:
>> maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java (contents, props changed)
>>
>> Modified: maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
>> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java?rev=1512672&r1=1512671&r2=1512672&view=diff
>> ==============================================================================
>> --- maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java (original)
>> +++ maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java Sat Aug 10 12:27:41 2013
>> @@ -31,7 +31,7 @@ import org.apache.maven.project.MavenPro
>> * A base class for all classes that implements signing of files.
>> *
>> * @author Dennis Lundberg
>> - * @version $Revision: 1.1 $ $Date: 2004/07/28 09:48:35 2013-08-10 14:10 $
>> + * @version $Revision$ $Date$
>
> Date causes problems.
> The value and format depends on the user's locale, so source archives
> will vary depending on where they were created.
>
> If you really need a timestamp (why?), use $Id$ instead.
>
>> * @since 1.5
>> */
>> public abstract class AbstractGpgSigner
>>
>> Propchange: maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
>> ------------------------------------------------------------------------------
>> svn:keywords = Date Revision Author Id
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1512672 - /maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
Posted by sebb <se...@gmail.com>.
On 10 August 2013 13:27, <de...@apache.org> wrote:
> Author: dennisl
> Date: Sat Aug 10 12:27:41 2013
> New Revision: 1512672
>
> URL: http://svn.apache.org/r1512672
> Log:
> Add subversion keywords.
>
> Modified:
> maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java (contents, props changed)
>
> Modified: maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java?rev=1512672&r1=1512671&r2=1512672&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java (original)
> +++ maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java Sat Aug 10 12:27:41 2013
> @@ -31,7 +31,7 @@ import org.apache.maven.project.MavenPro
> * A base class for all classes that implements signing of files.
> *
> * @author Dennis Lundberg
> - * @version $Revision: 1.1 $ $Date: 2004/07/28 09:48:35 2013-08-10 14:10 $
> + * @version $Revision$ $Date$
Date causes problems.
The value and format depends on the user's locale, so source archives
will vary depending on where they were created.
If you really need a timestamp (why?), use $Id$ instead.
> * @since 1.5
> */
> public abstract class AbstractGpgSigner
>
> Propchange: maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
> ------------------------------------------------------------------------------
> svn:keywords = Date Revision Author Id
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org