You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mahesh Reddy (Code Review)" <ge...@cloudera.org> on 2022/07/20 03:17:43 UTC
[kudu-CR] WIP KUDU-2671: Backup/restore for custom hash schema
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18753
Change subject: WIP KUDU-2671: Backup/restore for custom hash schema
......................................................................
WIP KUDU-2671: Backup/restore for custom hash schema
WIP:
- Add tests for tables with custom hash schema per range
- Modify getPartitionSchema() in TableMetadata.scala to
include the ranges with custom hash schemas.
Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
3 files changed, 46 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18753/1
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] WIP KUDU-2671: Backup/restore for custom hash schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18753 )
Change subject: WIP KUDU-2671: Backup/restore for custom hash schema
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18753/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18753/2//COMMIT_MSG@7
PS2, Line 7: WIP KUDU-2671: Backup/restore for custom hash schema
It would help if this commit message outlines what's been done in the context of the patch.
http://gerrit.cloudera.org:8080/#/c/18753/2//COMMIT_MSG@10
PS2, Line 10: - Add tests for tables with custom hash schema per range
How about tests verifying compatibility between versions of the backup tools while working on backup data generated for tables with and without ranges having custom hash schemas?
Is it possible to automate that or the idea is to check for that once manually?
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 19:14:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18753 )
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@604
PS3, Line 604: AlterTableOptions()
I think it makes sense to add a new range partition with custom hash schema here and validate the incremental backup.
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 3
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 17:59:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18753 )
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 5
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 22:09:15 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18753 )
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto
File java/kudu-backup-common/src/main/protobuf/backup.proto:
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto@94
PS3, Line 94: RangePartitionWithHashPartitionMetadataPB
nit: PartitionXPartition looks a bit long, how about renaming this into RangeWithCustomHashSchemaMetadataPB or RangeAndHashPartitionMetadataPB ?
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto@96
PS3, Line 96: hash_partitions
nit: we used to call structures like this 'hash_schema' in other protobuf files in src/kudu/common/common.proto Is anything specific why we call this 'hash_partitions' here?
http://gerrit.cloudera.org:8080/#/c/18753/4/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
File java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala:
http://gerrit.cloudera.org:8080/#/c/18753/4/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@405
PS4, Line 405: rangeWithHashSchema
nit: is this actually a collection/list? Then maybe name it 'rangesWithHashSchemas'
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 4
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 20:07:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18753 )
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto
File java/kudu-backup-common/src/main/protobuf/backup.proto:
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto@96
PS3, Line 96: hash_partitions
> Other instances in this protobuf file call it 'hash_partitions' so I just k
Sure, that makes sense. SGTM
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 5
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 21:51:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18753 )
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 5
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 22:53:49 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kurt Deschler, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18753
to look at the new patch set (#5).
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
KUDU-2671: Backup/restore for custom hash schema
This patch ensures that the ranges with custom
hash schemas are also backed up when the partition
schema is backed up.
Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
5 files changed, 137 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18753/5
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 5
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18753 )
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/18753/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18753/2//COMMIT_MSG@7
PS2, Line 7: KUDU-2671: Backup/restore for custom hash schema
> It would help if this commit message outlines what's been done in the conte
Done
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto
File java/kudu-backup-common/src/main/protobuf/backup.proto:
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto@94
PS3, Line 94: RangeAndHashPartitionMetadataPB {
> nit: PartitionXPartition looks a bit long, how about renaming this into Ran
Done
http://gerrit.cloudera.org:8080/#/c/18753/3/java/kudu-backup-common/src/main/protobuf/backup.proto@96
PS3, Line 96: hash_partitions
> nit: we used to call structures like this 'hash_schema' in other protobuf f
Other instances in this protobuf file call it 'hash_partitions' so I just kept it consistent with that.
http://gerrit.cloudera.org:8080/#/c/18753/4/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
File java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala:
http://gerrit.cloudera.org:8080/#/c/18753/4/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@405
PS4, Line 405: rangesWithHashSchem
> nit: is this actually a collection/list? Then maybe name it 'rangesWithHas
Done
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 5
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 21:00:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kurt Deschler, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18753
to look at the new patch set (#4).
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
KUDU-2671: Backup/restore for custom hash schema
This patch ensures that the ranges with custom
hash schemas are also backed up when the partition
schema is backed up.
Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
5 files changed, 135 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18753/4
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 4
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] WIP KUDU-2671: Backup/restore for custom hash schema
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kurt Deschler, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18753
to look at the new patch set (#2).
Change subject: WIP KUDU-2671: Backup/restore for custom hash schema
......................................................................
WIP KUDU-2671: Backup/restore for custom hash schema
WIP:
- Add tests for tables with custom hash schema per range
Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
3 files changed, 57 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18753/2
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kurt Deschler, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18753
to look at the new patch set (#3).
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
KUDU-2671: Backup/restore for custom hash schema
This patch ensures that the ranges with custom
hash schemas are also backed up when the partition
schema is backed up.
Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
5 files changed, 134 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/18753/3
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 3
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671: Backup/restore for custom hash schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18753 )
Change subject: KUDU-2671: Backup/restore for custom hash schema
......................................................................
KUDU-2671: Backup/restore for custom hash schema
This patch ensures that the ranges with custom
hash schemas are also backed up when the partition
schema is backed up.
Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Reviewed-on: http://gerrit.cloudera.org:8080/18753
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
5 files changed, 137 insertions(+), 4 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b8e0481e4e9bc0ac0e5fcbf085976325dd55b0d
Gerrit-Change-Number: 18753
Gerrit-PatchSet: 6
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>