[GitHub] [hive] veghlaci05 commented on a diff in pull request #4306: HIVE-27330: Compaction entry dequeue order

["veghlaci05 (via GitHub)" <gi...@apache.org>]

veghlaci05 commented on code in PR #4306:
URL: https://github.com/apache/hive/pull/4306#discussion_r1191560586


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -258,6 +258,7 @@ public CompactionInfo findNextToCompact(FindNextCompactRequest rqst) throws Meta
           sb.append("\"CQ_POOL_NAME\" IS NULL OR  \"CQ_ENQUEUE_TIME\" < (")
             .append(getEpochFn(dbProduct)).append(" - ").append(poolTimeout).append(")");
         }
+        sb.append(" ORDER BY CQ_ID ASC");

Review Comment:
   Actually I prefer writing old school SQL code. ORM tools are great simple CRUD, but when the query is getting more complex than a select with a where, you will end up using a ton of annotations and JPQL wich IMHO neither less complex nor faster compared to plain old SQL. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org