[GitHub] [helix] jiajunwang commented on a change in pull request #1460: Allow Stale Reply Messages to Pass without Exceptions

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1460:
URL: https://github.com/apache/helix/pull/1460#discussion_r504343539



##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/AsyncCallbackService.java
##########
@@ -62,15 +62,6 @@ void verifyMessage(Message message) {
       throw new HelixException(errorMsg);
     }
 

Review comment:
       Alternatively, if the exception is not graceful, we can return null when createHandler() is triggered. This is much better than returning a handler that does nothing (but still consume system resources).
   Of course, the callers of createHandler() need to be improved to tolerate the null return value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org