You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/04/29 00:08:25 UTC

Re: Review Request 46796: Synced endpoint documentation by running generation script.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/
-----------------------------------------------------------

(Updated April 28, 2016, 10:08 p.m.)


Review request for mesos, Greg Mann, haosdent huang, and Vinod Kone.


Repository: mesos


Description (updated)
-------

https://reviews.apache.org/r/46472/ introduced some manual changed to
the endpoint documentation. This review syncs the actual endpoint
documentation with the generated one.
Note that the removal of metrics/snapshot is a separate issue tracked 
by MESOS-5304.


Diffs
-----

  docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
  docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 

Diff: https://reviews.apache.org/r/46796/diff/


Testing
-------


Thanks,

Joerg Schad


Re: Review Request 46796: Synced endpoint documentation by running generation script.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/#review131022
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46796]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 28, 2016, 10:08 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46796/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 10:08 p.m.)
> 
> 
> Review request for mesos, Greg Mann, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> https://reviews.apache.org/r/46472/ introduced some manual changed to
> the endpoint documentation. This review syncs the actual endpoint
> documentation with the generated one.
> Note that the removal of metrics/snapshot is a separate issue tracked 
> by MESOS-5304.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
>   docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
> 
> Diff: https://reviews.apache.org/r/46796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 46796: Synced endpoint documentation by running generation script.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/#review131119
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46796]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 9:57 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46796/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 9:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> https://reviews.apache.org/r/46472/ introduced some manual changed to
> the endpoint documentation. This review syncs the actual endpoint
> documentation with the generated one.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
>   docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
> 
> Diff: https://reviews.apache.org/r/46796/diff/
> 
> 
> Testing
> -------
> 
> make check + viewed endpoint docs
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 46796: Synced endpoint documentation by running generation script.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/#review131116
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On April 29, 2016, 9:57 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46796/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 9:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> https://reviews.apache.org/r/46472/ introduced some manual changed to
> the endpoint documentation. This review syncs the actual endpoint
> documentation with the generated one.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
>   docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
> 
> Diff: https://reviews.apache.org/r/46796/diff/
> 
> 
> Testing
> -------
> 
> make check + viewed endpoint docs
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 46796: Synced endpoint documentation by running generation script.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/#review131073
-----------------------------------------------------------


Ship it!




Ship It!

- haosdent huang


On April 29, 2016, 9:57 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46796/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 9:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> https://reviews.apache.org/r/46472/ introduced some manual changed to
> the endpoint documentation. This review syncs the actual endpoint
> documentation with the generated one.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
>   docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
> 
> Diff: https://reviews.apache.org/r/46796/diff/
> 
> 
> Testing
> -------
> 
> make check + viewed endpoint docs
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 46796: Synced endpoint documentation by running generation script.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/
-----------------------------------------------------------

(Updated April 29, 2016, 9:57 a.m.)


Review request for mesos, Alexander Rukletsov, Greg Mann, haosdent huang, and Vinod Kone.


Repository: mesos


Description
-------

https://reviews.apache.org/r/46472/ introduced some manual changed to
the endpoint documentation. This review syncs the actual endpoint
documentation with the generated one.


Diffs
-----

  docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
  docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 

Diff: https://reviews.apache.org/r/46796/diff/


Testing
-------

make check + viewed endpoint docs


Thanks,

Joerg Schad


Re: Review Request 46796: Synced endpoint documentation by running generation script.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46796/
-----------------------------------------------------------

(Updated April 29, 2016, 9:57 a.m.)


Review request for mesos, Alexander Rukletsov, Greg Mann, haosdent huang, and Vinod Kone.


Repository: mesos


Description (updated)
-------

https://reviews.apache.org/r/46472/ introduced some manual changed to
the endpoint documentation. This review syncs the actual endpoint
documentation with the generated one.


Diffs (updated)
-----

  docs/endpoints/index.md 8ef110f972942dad8e9310b2cdf1f395b4a60fdb 
  docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 

Diff: https://reviews.apache.org/r/46796/diff/


Testing (updated)
-------

make check + viewed endpoint docs


Thanks,

Joerg Schad