[GitHub] [hudi] codope commented on a diff in pull request #8397: [HUDI-6055] Fix input format for bootstrap tables

["codope (via GitHub)" <gi...@apache.org>]

codope commented on code in PR #8397:
URL: https://github.com/apache/hudi/pull/8397#discussion_r1186702204


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HiveHoodieTableFileIndex.java:
##########
@@ -58,7 +58,7 @@ public HiveHoodieTableFileIndex(HoodieEngineContext engineContext,
         shouldIncludePendingCommits,
         true,
         new NoopCache(),
-        false);
+        true);

Review Comment:
   Yes, this should not have been part of this PR. Actually, it doesn't really matter for Hudi connector as it doesn't go through COW input format code. And for Hive connector, we already saw that it was partition loader will instantiate this every call. However, the actual perf issue for Hive connector was fixed due to https://github.com/apache/hudi/pull/7527#discussion_r1054022432
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org