You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/29 16:16:27 UTC
[jira] [Commented] (ARTEMIS-288) Disconnecting client results in
log warnings
[ https://issues.apache.org/jira/browse/ARTEMIS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980603#comment-14980603 ]
ASF GitHub Bot commented on ARTEMIS-288:
----------------------------------------
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/223
ARTEMIS-288 Start close method in separate executor
When server sends disconnect to the client, the ClientSession schedules
a close task on it's ordered executor. Once the close method starts
it's waits to check to see if all jobs in it's executor has completed.
To do this it adds a job to it's ordered executor, once it is run it
knows there is nothing more to do and thus is ready to close. However,
this causes a deadlock as both jobs are running in the ordered executor
and thus are both waiting on each other. The close eventually timesout
which is why we see the logs as reported in the JIRA.
This commit runs the close method in it's own ordered executor, thus
preventing the two jobs blocking each other.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-288-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #223
----
commit 26898e4663ce00468ec9cebf00c57d72658dd191
Author: Martyn Taylor <mt...@redhat.com>
Date: 2015-10-29T12:50:08Z
ARTEMIS-288 Start close method in separate executor
When server sends disconnect to the client, the ClientSession schedules
a close task on it's ordered executor. Once the close method starts
it's waits to check to see if all jobs in it's executor has completed.
To do this it adds a job to it's ordered executor, once it is run it
knows there is nothing more to do and thus is ready to close. However,
this causes a deadlock as both jobs are running in the ordered executor
and thus are both waiting on each other. The close eventually timesout
which is why we see the logs as reported in the JIRA.
This commit runs the close method in it's own ordered executor, thus
preventing the two jobs blocking each other.
----
> Disconnecting client results in log warnings
> --------------------------------------------
>
> Key: ARTEMIS-288
> URL: https://issues.apache.org/jira/browse/ARTEMIS-288
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Martyn Taylor
>
> When the server sends a disconnect to a client. The client logs a bunch of warning messages, and then an error.
> 11:18:54,630 WARN [org.apache.activemq.artemis.core.client] (Thread-2 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,630 WARN [org.apache.activemq.artemis.core.client] (Thread-18 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,630 WARN [org.apache.activemq.artemis.core.client] (Thread-4 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,631 WARN [org.apache.activemq.artemis.core.client] (Thread-13 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,631 WARN [org.apache.activemq.artemis.core.client] (Thread-14 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,630 WARN [org.apache.activemq.artemis.core.client] (Thread-11 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,631 WARN [org.apache.activemq.artemis.core.client] (Thread-12 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,630 WARN [org.apache.activemq.artemis.core.client] (Thread-7 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,631 WARN [org.apache.activemq.artemis.core.client] (Thread-17 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,630 WARN [org.apache.activemq.artemis.core.client] (Thread-9 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,630 WARN [org.apache.activemq.artemis.core.client] (Thread-19 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,631 WARN [org.apache.activemq.artemis.core.client] (Thread-10 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,630 WARN [org.apache.activemq.artemis.core.client] (Thread-21 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,630 WARN [org.apache.activemq.artemis.core.client] (Thread-22 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
> 11:18:54,631 WARN [org.apache.activemq.artemis.core.client] (Thread-16 (ActiveMQ-client-global-threads-633087758)) AMQ212002: Timed out waiting for handler to complete processing
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)