You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "zoudan (via GitHub)" <gi...@apache.org> on 2023/04/16 04:04:24 UTC

[GitHub] [calcite] zoudan commented on a diff in pull request #3142: [CALCITE-5634] Add LEAST, GREATEST for PostgreSQL

zoudan commented on code in PR #3142:
URL: https://github.com/apache/calcite/pull/3142#discussion_r1167689297


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -383,14 +383,14 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding operatorBinding,
       SUBSTR.withKind(SqlKind.SUBSTR_POSTGRESQL);
 
   /** The "GREATEST(value, value)" function. */
-  @LibraryOperator(libraries = {BIG_QUERY, ORACLE})
+  @LibraryOperator(libraries = {BIG_QUERY, ORACLE, POSTGRESQL})

Review Comment:
   could you please improve UT in `SqlOperatorTest`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org