You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by windpiger <gi...@git.apache.org> on 2017/02/27 07:54:00 UTC

[GitHub] spark pull request #17079: [SPARK-19748][SQL]refresh function has an wrong o...

GitHub user windpiger opened a pull request:

    https://github.com/apache/spark/pull/17079

    [SPARK-19748][SQL]refresh function has an wrong order to do cache invalidate and regenerate the inmemory var for InMemoryFileIndex with FileStatusCache

    ## What changes were proposed in this pull request?
    
    If we refresh a InMemoryFileIndex with a FileStatusCache, it will first use the FileStatusCache to re-generate the cachedLeafFiles etc, then call FileStatusCache.invalidateAll. 
    
    While the order to do these two actions is wrong, this lead to the refresh action does not take effect.
    
    ```
      override def refresh(): Unit = {
        refresh0()
        fileStatusCache.invalidateAll()
      }
    
      private def refresh0(): Unit = {
        val files = listLeafFiles(rootPaths)
        cachedLeafFiles =
          new mutable.LinkedHashMap[Path, FileStatus]() ++= files.map(f => f.getPath -> f)
        cachedLeafDirToChildrenFiles = files.toArray.groupBy(_.getPath.getParent)
        cachedPartitionSpec = null
      }
    ```
    ## How was this patch tested?
    unit test added

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/windpiger/spark fixInMemoryFileIndexRefresh

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17079
    
----
commit 552955a5293bc22da1cd644ffde90b883fc560e8
Author: windpiger <so...@outlook.com>
Date:   2017-02-27T07:46:18Z

    [SPARK-19748][SQL]refresh function has an wrong order to do cache invalidate and regenerate the inmemory var for InMemoryFileIndex with FileStatusCache

commit fd3bb21597809409e7f33796589c9178744063c5
Author: windpiger <so...@outlook.com>
Date:   2017-02-27T07:53:46Z

    modify the test case

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17079: [SPARK-19748][SQL]refresh function has a wrong or...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17079#discussion_r103350023
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala ---
    @@ -178,6 +178,34 @@ class FileIndexSuite extends SharedSQLContext {
           assert(catalog2.allFiles().nonEmpty)
         }
       }
    +
    +  test("refresh for InMemoryFileIndex with FileStatusCache") {
    +    withTempDir { dir =>
    +      val fileStatusCache = FileStatusCache.getOrCreate(spark)
    +      val dirPath = new Path(dir.getAbsolutePath)
    +      val catalog = new InMemoryFileIndex(spark, Seq(dirPath), Map.empty,
    +        None, fileStatusCache) {
    +        def leafFilePaths: Seq[Path] = leafFiles.keys.toSeq
    +        def leafDirPaths: Seq[Path] = leafDirToChildrenFiles.keys.toSeq
    +      }
    +
    +      assert(catalog.leafDirPaths.isEmpty)
    +      assert(catalog.leafFilePaths.isEmpty)
    +
    +      val file = new File(dir, "text.txt")
    +      stringToFile(file, "text")
    +
    +      catalog.refresh()
    +
    +      assert(catalog.leafFilePaths.size == 1)
    +      assert(catalog.leafFilePaths.head.toString.stripSuffix("/") ==
    +        s"file:${file.getAbsolutePath.stripSuffix("/")}")
    --- End diff --
    
    this looks hacky, can you turn them into `Path` and compare?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17079: [SPARK-19748][SQL]refresh function has a wrong or...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17079#discussion_r103349639
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala ---
    @@ -178,6 +178,34 @@ class FileIndexSuite extends SharedSQLContext {
           assert(catalog2.allFiles().nonEmpty)
         }
       }
    +
    +  test("refresh for InMemoryFileIndex with FileStatusCache") {
    +    withTempDir { dir =>
    +      val fileStatusCache = FileStatusCache.getOrCreate(spark)
    +      val dirPath = new Path(dir.getAbsolutePath)
    +      val catalog = new InMemoryFileIndex(spark, Seq(dirPath), Map.empty,
    +        None, fileStatusCache) {
    --- End diff --
    
    nit:
    ```
    val catalog =
      new XXX(...) {
        def xxx
      }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17079: [SPARK-19748][SQL]refresh function has a wrong or...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/17079


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17079: [SPARK-19748][SQL]refresh function has a wrong or...

Posted by windpiger <gi...@git.apache.org>.
Github user windpiger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17079#discussion_r103357633
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala ---
    @@ -178,6 +178,34 @@ class FileIndexSuite extends SharedSQLContext {
           assert(catalog2.allFiles().nonEmpty)
         }
       }
    +
    +  test("refresh for InMemoryFileIndex with FileStatusCache") {
    +    withTempDir { dir =>
    +      val fileStatusCache = FileStatusCache.getOrCreate(spark)
    +      val dirPath = new Path(dir.getAbsolutePath)
    +      val catalog = new InMemoryFileIndex(spark, Seq(dirPath), Map.empty,
    +        None, fileStatusCache) {
    +        def leafFilePaths: Seq[Path] = leafFiles.keys.toSeq
    +        def leafDirPaths: Seq[Path] = leafDirToChildrenFiles.keys.toSeq
    +      }
    +
    +      assert(catalog.leafDirPaths.isEmpty)
    +      assert(catalog.leafFilePaths.isEmpty)
    +
    +      val file = new File(dir, "text.txt")
    +      stringToFile(file, "text")
    +
    +      catalog.refresh()
    +
    +      assert(catalog.leafFilePaths.size == 1)
    +      assert(catalog.leafFilePaths.head.toString.stripSuffix("/") ==
    +        s"file:${file.getAbsolutePath.stripSuffix("/")}")
    --- End diff --
    
    ok, let me modify~ thanks~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17079: [SPARK-19748][SQL]refresh function has a wrong or...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17079#discussion_r103373646
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala ---
    @@ -178,6 +178,33 @@ class FileIndexSuite extends SharedSQLContext {
           assert(catalog2.allFiles().nonEmpty)
         }
       }
    +
    +  test("refresh for InMemoryFileIndex with FileStatusCache") {
    +    withTempDir { dir =>
    +      val fileStatusCache = FileStatusCache.getOrCreate(spark)
    +      val dirPath = new Path(dir.getAbsolutePath)
    +      val fs = dirPath.getFileSystem(spark.sessionState.newHadoopConf())
    +      val catalog =
    +        new InMemoryFileIndex(spark, Seq(dirPath), Map.empty, None, fileStatusCache) {
    +        def leafFilePaths: Seq[Path] = leafFiles.keys.toSeq
    +        def leafDirPaths: Seq[Path] = leafDirToChildrenFiles.keys.toSeq
    +      }
    --- End diff --
    
    Nit: Indents issues for the above three lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    **[Test build #73546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73546/testReport)** for PR 17079 at commit [`1ec20a5`](https://github.com/apache/spark/commit/1ec20a5146e7e7c79386d0c0e9fdffad3254cdc6).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    LGTM except two minor comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    **[Test build #73560 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73560/testReport)** for PR 17079 at commit [`94879a8`](https://github.com/apache/spark/commit/94879a8528a3d50cf67c8952b05ac9e408f5ecdd).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by windpiger <gi...@git.apache.org>.
Github user windpiger commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    there is no related test case for InMemoryFileIndex with FileStatusCache.
    When I do this [PR](https://github.com/apache/spark/pull/17081), and add a fileStatusCache in DataSource, I found this bug..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17079: [SPARK-19748][SQL]refresh function has a wrong or...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17079#discussion_r103373620
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala ---
    @@ -178,6 +178,33 @@ class FileIndexSuite extends SharedSQLContext {
           assert(catalog2.allFiles().nonEmpty)
         }
       }
    +
    +  test("refresh for InMemoryFileIndex with FileStatusCache") {
    +    withTempDir { dir =>
    +      val fileStatusCache = FileStatusCache.getOrCreate(spark)
    +      val dirPath = new Path(dir.getAbsolutePath)
    +      val fs = dirPath.getFileSystem(spark.sessionState.newHadoopConf())
    +      val catalog =
    +        new InMemoryFileIndex(spark, Seq(dirPath), Map.empty, None, fileStatusCache) {
    +        def leafFilePaths: Seq[Path] = leafFiles.keys.toSeq
    +        def leafDirPaths: Seq[Path] = leafDirToChildrenFiles.keys.toSeq
    +      }
    +
    +      assert(catalog.leafDirPaths.isEmpty)
    +      assert(catalog.leafFilePaths.isEmpty)
    --- End diff --
    
    Move these two asserts after `stringToFile`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by windpiger <gi...@git.apache.org>.
Github user windpiger commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    cc @cloud-fan @gatorsmile


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    **[Test build #73502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73502/testReport)** for PR 17079 at commit [`fd3bb21`](https://github.com/apache/spark/commit/fd3bb21597809409e7f33796589c9178744063c5).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    **[Test build #73560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73560/testReport)** for PR 17079 at commit [`94879a8`](https://github.com/apache/spark/commit/94879a8528a3d50cf67c8952b05ac9e408f5ecdd).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73560/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73502/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    thanks, merging to master/2.1!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    good catch! Can you show a real example that fails because of this bug? I'm wondering why the existing unit tests didn't expose this bug...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73546/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    **[Test build #73546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73546/testReport)** for PR 17079 at commit [`1ec20a5`](https://github.com/apache/spark/commit/1ec20a5146e7e7c79386d0c0e9fdffad3254cdc6).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17079: [SPARK-19748][SQL]refresh function has a wrong order to ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17079
  
    **[Test build #73502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73502/testReport)** for PR 17079 at commit [`fd3bb21`](https://github.com/apache/spark/commit/fd3bb21597809409e7f33796589c9178744063c5).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org