You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/07 09:28:15 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25117: [SPARK-28454][PYTHON] Validate LongType in `createDataFrame(verifySchema=True)`

HyukjinKwon commented on a change in pull request #25117: [SPARK-28454][PYTHON] Validate LongType in `createDataFrame(verifySchema=True)`
URL: https://github.com/apache/spark/pull/25117#discussion_r311455608
 
 

 ##########
 File path: docs/sql-migration-guide-upgrade.md
 ##########
 @@ -149,6 +149,8 @@ license: |
 
   - Since Spark 3.0, if files or subdirectories disappear during recursive directory listing (i.e. they appear in an intermediate listing but then cannot be read or listed during later phases of the recursive directory listing, due to either concurrent file deletions or object store consistency issues) then the listing will fail with an exception unless `spark.sql.files.ignoreMissingFiles` is `true` (default `false`). In previous versions, these missing files or subdirectories would be ignored. Note that this change of behavior only applies during initial table file listing (or during `REFRESH TABLE`), not during query execution: the net change is that `spark.sql.files.ignoreMissingFiles` is now obeyed during table file listing / query planning, not only at query execution time.
 
+  - Since Spark 3.0, missing validation of `LongType` value in pyspark's `createDataframe` added. Previously `LongType` was not verified and resulted in `None` in case of wrong value. To have `None` instead of any validation error set `verifySchema=False`.
 
 Review comment:
   Let's match the wording `pyspark` -> `PySpark`.
   `createDataframe` -> `createDataFrame`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org