You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Dan Benediktson <db...@twitter.com.INVALID> on 2017/05/01 23:11:13 UTC

Re: [jira] [Commented] (ZOOKEEPER-2260) Paginated getChildren call

What's happening with this PR? We're pretty interested in the feature and
would love to see it adopted into the OSS tree, and it looks like it has
already had review feedback addressed and been signed off by Jenkins.

On Tue, Apr 11, 2017 at 2:16 PM, Hadoop QA (JIRA) <ji...@apache.org> wrote:

>
>     [ https://issues.apache.org/jira/browse/ZOOKEEPER-2260?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&
> focusedCommentId=15964970#comment-15964970 ]
>
> Hadoop QA commented on ZOOKEEPER-2260:
> --------------------------------------
>
> +1 overall.  GitHub Pull Request  Build
>
>
>     +1 @author.  The patch does not contain any @author tags.
>
>     +1 tests included.  The patch appears to include 15 new or modified
> tests.
>
>     +1 javadoc.  The javadoc tool did not generate any warning messages.
>
>     +1 javac.  The applied patch does not increase the total number of
> javac compiler warnings.
>
>     +1 findbugs.  The patch does not introduce any new Findbugs (version
> 3.0.1) warnings.
>
>     +1 release audit.  The applied patch does not increase the total
> number of release audit warnings.
>
>     +1 core tests.  The patch passed core unit tests.
>
>     +1 contrib tests.  The patch passed contrib unit tests.
>
> Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-
> build/535//testReport/
> Findbugs warnings: https://builds.apache.org/job/
> PreCommit-ZOOKEEPER-github-pr-build/535//artifact/trunk/
> build/test/findbugs/newPatchFindbugsWarnings.html
> Console output: https://builds.apache.org/job/
> PreCommit-ZOOKEEPER-github-pr-build/535//console
>
> This message is automatically generated.
>
> > Paginated getChildren call
> > --------------------------
> >
> >                 Key: ZOOKEEPER-2260
> >                 URL: https://issues.apache.org/
> jira/browse/ZOOKEEPER-2260
> >             Project: ZooKeeper
> >          Issue Type: New Feature
> >    Affects Versions: 3.4.6, 3.5.0
> >            Reporter: Marco P.
> >            Assignee: Marco P.
> >              Labels: api, features
> >             Fix For: 3.5.4, 3.6.0
> >
> >         Attachments: ZOOKEEPER-2260.patch, ZOOKEEPER-2260.patch
> >
> >
> > Add pagination support to the getChildren() call, allowing clients to
> iterate over children N at the time.
> > Motivations for this include:
> >   - Getting out of a situation where so many children were created that
> listing them exceeded the network buffer sizes (making it impossible to
> recover by deleting)[1]
> >  - More efficient traversal of nodes with large number of children [2]
> > I do have a patch (for 3.4.6) we've been using successfully for a while,
> but I suspect much more work is needed for this to be accepted.
> > [1] https://issues.apache.org/jira/browse/ZOOKEEPER-272
> > [2] https://issues.apache.org/jira/browse/ZOOKEEPER-282
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>