You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by arina-ielchiieva <gi...@git.apache.org> on 2018/01/10 12:48:20 UTC

[GitHub] drill pull request #1078: DRILL-6054: don't try to split the filter when it ...

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1078#discussion_r160665449
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java ---
    @@ -195,8 +195,16 @@ private void popOpStackAndBuildFilter() {
              * For all other operators we clear the children if one of the
              * children is a no push.
              */
    -        assert currentOp.getOp().getKind() == SqlKind.AND;
    -        newFilter = currentOp.getChildren().get(0);
    +        if (currentOp.getOp().getKind() == SqlKind.AND) {
    +          newFilter = currentOp.getChildren().get(0);
    +          for(OpState opState : opStack) {
    --- End diff --
    
    Please add space: `for (`


---