You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2010/08/12 03:52:17 UTC

[jira] Closed: (THRIFT-570) Thrift compiler does not error when duplicate method names are present

     [ https://issues.apache.org/jira/browse/THRIFT-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-570.
--------------------------------

         Assignee: Bruce Simpson
    Fix Version/s: 0.4
       Resolution: Fixed

I just committed this patch with slight modifications. Thanks for the patch, Bruce!

> Thrift compiler does not error when duplicate method names are present
> ----------------------------------------------------------------------
>
>                 Key: THRIFT-570
>                 URL: https://issues.apache.org/jira/browse/THRIFT-570
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (C#), Compiler (C++), Compiler (Cocoa), Compiler (Erlang), Compiler (General), Compiler (Haskell), Compiler (Java), Compiler (Perl), Compiler (PHP), Compiler (Python), Compiler (Ruby)
>            Reporter: Rob Slifka
>            Assignee: Bruce Simpson
>             Fix For: 0.4
>
>         Attachments: 570.diff
>
>
> Thrift does not support method overloading.  However, the Thrift compiler reports success when duplicate methods are seen in a service definition.
> Thrift compiles this successfully, however the generated code will not compile.
> {code}
> #!/usr/local/bin/thrift --gen java
> namespace java tutorial
> service Calculator {
>     i32 add(1:i32 num1, 2:i32 num2),
>     string add(1:string str1, 2:string str2),
> }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.