[GitHub] [superset] graceguo-supercat edited a comment on pull request #16367: fix: Disable Slack notification method if no api token

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on pull request #16367:
URL: https://github.com/apache/superset/pull/16367#issuecomment-904015848


   > Alternatively, we can show the Slack option only if `SLACK_API_TOKEN` is defined in the config.
   
   I actually think this is a good idea:
   - We should not show Slack if api token is None. Right now we show Slack as notification method even no API token set, this is not a correct behavior.
   - If we set `ALERT_REPORTS_NOTIFICATION_METHODS` internally (not in config.py), it could avoid circular dependency. otherwise, move those constants will touch about 20 files which makes me feel dangerous.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org