[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9442: Support Elasticsearch column alias for the compatibility between storage logicSharding model and no-logicSharding model.

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #9442:
URL: https://github.com/apache/skywalking/pull/9442#discussion_r940937420


##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/ElasticSearch.java:
##########
@@ -68,4 +68,18 @@ enum AnalyzerType {
             }
         }
     }
+
+    @Target({ElementType.FIELD})
+    @Retention(RetentionPolicy.RUNTIME)
+    @interface Column {
+
+        /**
+         * Warning: this is only used to solve the excited column conflict since we need support merge all metrics
+         * in one index or sharding storage type both. If create a new a column, we should avoid the compatibility issue
+         * between these 2 storage type rather than use this alias.

Review Comment:
   ```suggestion
            * Warning: this is only used to solve the conflict among the exciting columns since we need support to merge all metrics
            * in one physical index template. When create a new column, we should avoid the compatibility issue
            * between these 2 storage modes rather than use this alias.
   ```



##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/ElasticSearch.java:
##########
@@ -68,4 +68,18 @@ enum AnalyzerType {
             }
         }
     }
+
+    @Target({ElementType.FIELD})
+    @Retention(RetentionPolicy.RUNTIME)
+    @interface Column {
+
+        /**
+         * Warning: this is only used to solve the excited column conflict since we need support merge all metrics
+         * in one index or sharding storage type both. If create a new a column, we should avoid the compatibility issue
+         * between these 2 storage type rather than use this alias.

Review Comment:
   ```suggestion
            * Warning: this is only used to solve the conflict among the exciting columns since we need support to merge all metrics
            * in one physical index template. When creating a new column, we should avoid the compatibility issue
            * between these 2 storage modes rather than use this alias.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org