You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "bluewang (via GitHub)" <gi...@apache.org> on 2023/06/09 07:57:26 UTC
[GitHub] [inlong] bluewang opened a new pull request, #8205: [INLONG-8204][Dashboard] Support querying audit information by sink id
bluewang opened a new pull request, #8205:
URL: https://github.com/apache/inlong/pull/8205
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes https://github.com/apache/inlong/issues/8204
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #8205: [INLONG-8204][Dashboard] Support querying audit information by sink id
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow merged PR #8205:
URL: https://github.com/apache/inlong/pull/8205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #8205: [INLONG-8204][Dashboard] Support querying audit information by sink id
Posted by "leezng (via GitHub)" <gi...@apache.org>.
leezng commented on code in PR #8205:
URL: https://github.com/apache/inlong/pull/8205#discussion_r1226218057
##########
inlong-dashboard/src/ui/locales/cn.json:
##########
@@ -623,6 +623,7 @@
"pages.GroupDetail.Audit.Min": "分钟",
"pages.GroupDetail.Audit.Hour": "小时",
"pages.GroupDetail.Audit.Day": "天",
+ "pages.GroupDetail.Audit.Sink": "数据目标",
Review Comment:
It should not be needed at present, this system-level naming is unified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #8205: [INLONG-8204][Dashboard] Support querying audit information by sink id
Posted by "leezng (via GitHub)" <gi...@apache.org>.
leezng commented on code in PR #8205:
URL: https://github.com/apache/inlong/pull/8205#discussion_r1226011241
##########
inlong-dashboard/src/ui/pages/GroupDetail/Audit/config.tsx:
##########
@@ -130,6 +130,34 @@ export const getFormContent = (inlongGroupId, initialValues, onSearch, onDataStr
},
rules: [{ required: true }],
},
+ {
+ type: 'select',
+ label: i18n.t('pages.GroupDetail.Audit.Sink'),
+ name: 'sinkId',
+ props: values => ({
+ dropdownMatchSelectWidth: false,
+ options: {
+ requestAuto: true,
Review Comment:
I think `requestAuto` can be unnecessary here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #8205: [INLONG-8204][Dashboard] Support querying audit information by sink id
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8205:
URL: https://github.com/apache/inlong/pull/8205#discussion_r1226047552
##########
inlong-dashboard/src/ui/locales/cn.json:
##########
@@ -623,6 +623,7 @@
"pages.GroupDetail.Audit.Min": "分钟",
"pages.GroupDetail.Audit.Hour": "小时",
"pages.GroupDetail.Audit.Day": "天",
+ "pages.GroupDetail.Audit.Sink": "数据目标",
Review Comment:
`数据写入` 是否更准确一些？它对应 `数据读取`。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org