[GitHub] [tvm] tqchen commented on a change in pull request #8802: Add LowerTEPass, and convert calls to LowerTE to application of LowerTEPass

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #8802:
URL: https://github.com/apache/tvm/pull/8802#discussion_r692557835



##########
File path: include/tvm/relay/function.h
##########
@@ -144,6 +144,8 @@ constexpr const char* kComposite = "Composite";
 constexpr const char* kInline = "Inline";
 /*! \brief Indicate the function was created by the Pattern Partitioning Pass. */
 constexpr const char* kPartitionedFromPattern = "PartitionedFromPattern";
+/*! \brief Indicate the target that the function should be lowered to. */
+constexpr const char* kTarget = "Target";

Review comment:
       The other "target" attr is used in https://github.com/apache/tvm/blob/main/include/tvm/ir/function.h#L170 for tir functions, would be great if we can consolidate




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org