[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #25189: Trim functions support

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu commented on code in PR #25189:
URL: https://github.com/apache/shardingsphere/pull/25189#discussion_r1168268410


##########
test/it/parser/src/main/resources/sql/supported/dml/select-special-function.xml:
##########
@@ -26,9 +26,9 @@
     <sql-case id="select_substring" value="SELECT SUBSTRING('foobarbar' from 4)" db-types="MySQL" />
     <sql-case id="select_extract" value="SELECT EXTRACT(YEAR FROM '2019-07-02')" db-types="MySQL" />
     <sql-case id="select_char" value="SELECT CHAR(77,121,83,81,'76')" db-types="MySQL" />
-    <sql-case id="select_trim" value="SELECT TRIM('  bar   ')" db-types="MySQL" />
-    <sql-case id="select_with_trim_expr" value="select trim('#' from `name`) from t_order" db-types="MySQL" />
-    <sql-case id="select_with_trim_expr_from_expr" value="select trim(remove_name from name) from t_order" db-types="MySQL" />
+    <sql-case id="select_trim" value="SELECT TRIM(BOTH ' ' from ' bar ')" db-types="MySQL" />

Review Comment:
   Why add BOTH keyword to these sql cases? Are they the wrong cases? If they are not wrong cases, I suggest adding cases to cover the logic we want to test.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org