[jira] [Commented] (MESOS-6056) add NOOP Container Logger for mesos

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427966#comment-15427966 ] 

ASF GitHub Bot commented on MESOS-6056:
---------------------------------------

GitHub user IvanJobs opened a pull request:

    https://github.com/apache/mesos/pull/159

    MESOS-6056 add NOOP Container Logger for mesos.

    mesos has two Container Loggers in its source files. 
    One is build into mesos-agent: sandbox Container Logger, it just redirects stderr/stdout to sandbox, causing fill disk usage problem.
    The other is LogrotateContainerLogger module lib, it's good, we can make sure stdout/stderr in sandbox be in a constant size.
    But there is a common need: don't write stdout/stderr into sandbox, pity, we don't have any flags for turning it off. 
    
    This is a come around for this: developing a new module lib for ContainerLogger for doing nothing(redirect stdout/stderr to /dev/null)
    
    yep, that's it. We need a NOOP ContainerLogger,.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/IvanJobs/mesos master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mesos/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
    
----
commit 3afdacffee17b87af6677b9dc7687022b76dea15
Author: IvanJobs <iv...@163.com>
Date:   2016-08-19T10:21:23Z

    MESOS-6056 add NOOP Container Logger for mesos.

----


> add NOOP Container Logger for mesos
> -----------------------------------
>
>                 Key: MESOS-6056
>                 URL: https://issues.apache.org/jira/browse/MESOS-6056
>             Project: Mesos
>          Issue Type: Improvement
>          Components: containerization, slave
>    Affects Versions: 1.0.0
>         Environment: mesos 1.0.0, docker
>            Reporter: IvanJobs
>            Priority: Trivial
>              Labels: easyfix, features
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> mesos has two Container Loggers in its source files. 
> One is build into mesos-agent: sandbox Container Logger, it just redirects stderr/stdout to sandbox, causing fill disk usage problem.
> The other is LogrotateContainerLogger module lib, it's good, we can make sure stdout/stderr in sandbox be in a constant size.
> But there is a common need: don't write stdout/stderr into sandbox, pity, we don't have any flags for turning it off. 
> This is a come around for this: developing a new module lib for ContainerLogger for doing nothing(redirect stdout/stderr to /dev/null)
> yep, that's it. We need a NOOP ContainerLogger, BTW, FYI, we can also retrieve stderr/stdout from docker daemon either.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)