[GitHub] vdiravka commented on a change in pull request #1657: DRILL-5603: Replace String file paths to Hadoop Path

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #1657: DRILL-5603: Replace String file paths to Hadoop Path
URL: https://github.com/apache/drill/pull/1657#discussion_r261765952
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
 ##########
 @@ -420,9 +423,10 @@ protected void doOnMatch(RelOptRuleCall call, Filter filterRel, Project projectR
             }
           }
           for (int j=0; j <= index; j++) {
-            path += "/" + spInfo[j];
+            path.append("/")
+                .append(spInfo[j]);
           }
-          cacheFileRoot = descriptor.getBaseTableLocation() + path;
+          cacheFileRoot = Path.mergePaths(descriptor.getBaseTableLocation(), createPathSafe(path.toString()));
 
 Review comment:
   Done. The same is done for `FileSelection` and `TestFileSelection`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services